feat: limit order mobile view #8073
Open
+158
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xApotheosis
force-pushed
the
limit-mobile-orders
branch
from
e257824
to
71ad733
Compare
NeOMakinG
approved these changes
Nov 5, 2024
src/components/MultiHopTrade/components/LimitOrder/LimitOrderList.tsx
Outdated
Show resolved
Hide resolved
| {onBack && ( | ||
| <CardHeader px={0} display='flex' flexDirection='column' pb={0}> | ||
| <Flex width='full' alignItems='center' mb={4} position='relative' mx={4}> | ||
| <Box position='absolute' left={0}> |
There was a problem hiding this comment.
preferably-blocking: avoid the position absolute which could cause z-index/hover issues and where the back button could not be clickable because of siblings elements
0xApotheosis
force-pushed
the
limit-mobile-orders
branch
from
890fbf2
to
f1264e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LimitOrderListandQuoteListIssue (if applicable)
Closes #6206
Risk
Small
None
Testing
With a small screen size, check that the clicking the limit order quote section navigates to a new route (
/trade/limit-order-quote-list) and shows the limit order list. Note, currently for this to work you must first get a quote on the Trade/Bridge tab.Ensure the back button works, navigating back to the limit order screen.
Ensure that the existing trade quote views (small and regular) have no regressions.
Engineering
☝️
Operations
Nothing needed from ops yet.
Screenshots (if applicable)