Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send revalidation not executed when going back and forth #8078

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

NeOMakinG
Copy link
Collaborator

Description

If you first validate a send amount, then hit the back button, then directly go back to the amount screen, the validation is not executed anymore, so you can go further and finally fail at TX sending time because you don't have enough fee asset amount:

https://jam.dev/c/9193bccd-b2af-46a4-8354-ae542f7c66a8

Issue (if applicable)

closes #8035

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

See the jam in the description:

  • Use any non-fee asset, using an account where you don't have any fee assets (ex: 1 USDT but 0 POL)
  • Go to any send modal using the asset you have, go to the amount view and hit the max button, you should see the red button with "You don't have enough funds" message
  • Hit back button, directly hit the next button and see the blue button, you can go further but you don't have any fee assets

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/e841a32e-f761-4f3e-9603-a3cdf48223f1

@NeOMakinG NeOMakinG requested a review from a team as a code owner November 4, 2024 23:09
@NeOMakinG NeOMakinG changed the title fix: send revalidation not executed fix: send revalidation not executed when going back and forth Nov 4, 2024
@kaladinlight
Copy link
Contributor

test.mp4

holding state when going back and forth, but seeing the state get invalidated initially. Happening on prod as well btw.

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice one ser!

Repro'd in develop:

https://jam.dev/c/e139dbb4-eac0-472d-af9f-0d134e730c5a

And confirmed fixed in this diff:

https://jam.dev/c/a34306f8-4d6f-4b8a-ae3a-ce524de7c6cd

@NeOMakinG
Copy link
Collaborator Author

NeOMakinG commented Nov 5, 2024

379c1ce

Nice catch, 100% related to the issue too, fixed 3 bugs on the send feature in one day seems like a good ratio 😆

Fixed in 379c1ce

Please test it again and get this in 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect user has reject the transaction error
3 participants