Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: minimise asset data size #8423

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Dec 20, 2024

Description

Minimizes the size of generatedAssetData.json by a factor of 3x.

TODO:

  • Fix stale relatedAssetKey issue upstream
  • Remove full dataset unit test
  • Consume sortedAssetIds in redux
  • Encode common prefix of icon URLs for another 2x gain (total 6x reduction)
  • Encode relatedAssetIndex using the encoded assetIds

Issue (if applicable)

closes #8188

Risk

High Risk PRs Require 2 approvals

High risk.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

@woodenfurniture woodenfurniture changed the base branch from develop to related-asset-fix December 20, 2024 04:42
Base automatically changed from related-asset-fix to develop December 20, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

benchmark asset market cap queries and sorts
1 participant