feat: decouple network fees from quote #8432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
changed the title
gomesalexandre
commented
Dec 23, 2024
Comment on lines
+98
to
+102
| isLoading: | ||
| allowanceCryptoBaseUnitResult.isLoading || | ||
| evmFeesResult.isLoading || | ||
| allowanceCryptoBaseUnitResult.isRefetching || | ||
| evmFeesResult.isRefetching, |
There was a problem hiding this comment.
Allowance can and will refetch at interval, but we were not capturing this properly, meaning only initial loading state would trigger a skeleton
gomesalexandre
commented
Dec 23, 2024
| if (!isSolanaFeeData(step.feeData.chainSpecific)) throw Error('Unable to execute step') | ||
|
|
||
| const buildSwapTxInput: BuildSendApiTxInput<KnownChainIds.SolanaMainnet> = { | ||
| to: '', |
There was a problem hiding this comment.
Looks odd but is correct, same payload as getUnsignedSolanaTransaction, to gets added in adapter.buildSendApiTransaction() below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This is exclusively tackling network fees estimate for current hop, and is used within the new trade flow components.
This PR refetches network fees at interval for current hop, using similar logic as
getUnsignedXyzTransactionto get calldata and estimate network fees from that.TODO:
useTradeNetworkFeesCryptoBaseUnitinstead of colocated with tradeExecution<TradeConfirmFooter />remove from final quote (maybe?)probably not (at least not now)Issue (if applicable)
closes #8270
Risk
Low - new trade flow only, not in prod yet. Though, if we consider flagged paths as production paths, this should be considered medium risk, as displayed fees could be off, and Txs could fail as a result.
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/9cf1706f-53d3-46d0-9a4c-cafd5f494462