Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement splash page from designs #22

Open
3 of 5 tasks
jonathan-chin opened this issue Jul 13, 2022 · 7 comments
Open
3 of 5 tasks

implement splash page from designs #22

jonathan-chin opened this issue Jul 13, 2022 · 7 comments
Assignees
Labels
Milestone

Comments

@jonathan-chin
Copy link
Contributor

jonathan-chin commented Jul 13, 2022

  • include material ui
  • update Header component
  • create splash page content
  • solution for centralized CSS?
  • create footer component
@jonathan-chin jonathan-chin added this to the Nextjs unauthenticated views milestone Jul 13, 2022
@Quipiii
Copy link
Contributor

Quipiii commented Jul 13, 2022

@jonathan-chin I installed Material UI and SVG icons. Would you want me to switch to styled components instead of the default emotions that MUI is using?

@jonathan-chin
Copy link
Contributor Author

@Quipiii no idea. I haven't used styled components before mostly because I stuck with the older CSS / SCSS pattern for managing styling. I'm open to either.

you and @ChelleyD can discuss a bit and see which is better.

@jonathan-chin jonathan-chin modified the milestones: Nextjs unauthenticated views, Week 7 Sprint Jul 15, 2022
@jonathan-chin
Copy link
Contributor Author

for centralized CSS solution, we'll use MUI ThemeProvider. I think we can include that in /pages/_app.js

@Quipiii
Copy link
Contributor

Quipiii commented Jul 22, 2022

@jonathan-chin @ChelleyD I am running into that error again where the buttons are not appearing in the header. Except this time it's not grayed out like it was before. The issues are in lines 6-23 and 35-50.

@Quipiii
Copy link
Contributor

Quipiii commented Jul 29, 2022

  • Think about using a container to limit width of 'above the fold'.
  • Match header buttons to Lunacy designs.

@jonathan-chin
Copy link
Contributor Author

jonathan-chin commented Aug 8, 2022

index.js is in development.

  • images still need to be placed
  • create image from second screen in shape

@jonathan-chin
Copy link
Contributor Author

for centralized CSS solution, we've been using MUI themes and it seems capable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants