Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom attributes on network buttons #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add custom attributes on network buttons #24

wants to merge 5 commits into from

Conversation

lucasflomuller
Copy link

More details

I've added the possibility to use an options object on each network, the object has three attributes:

{
	icon: {}      // properties will override on the image tag
	text: {}      // properties will override the span tag
	container: {} // properties will override the container tag
}

This closes #13.

I added to the readme how to use it and updated the live demo. I didn't deploy any of it.

@lucasflomuller lucasflomuller self-assigned this Sep 16, 2020
hao-sharethis
hao-sharethis suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@hao-sharethis hao-sharethis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi lucas, this looks really good. but instead of nesting the icons into networks, can we do it with a new field icons under the property level? nesting into networks needs a lot other coupling services to update.

@lucasflomuller
Copy link
Author

Hi lucas, this looks really good. but instead of nesting the icons into networks, can we do it with a new field icons under the property level? nesting into networks needs a lot other coupling services to update.

Hi, @hao-sharethis, I did what you asked for, hopefully this is what you were requesting 😄

Let me know if you need any further changes, I'll be here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryant-sharethis bryant-sharethis Awaiting requested review from bryant-sharethis

@hao-sharethis hao-sharethis Awaiting requested review from hao-sharethis

At least 1 approving review is required to merge this pull request.

Assignees

@lucasflomuller lucasflomuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom icons for buttons
2 participants
@lucasflomuller @hao-sharethis