Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Explicitly warn against relying on result order for exec #1405

Merged
merged 1 commit into from
Oct 23, 2023
Merged

docs: Explicitly warn against relying on result order for exec #1405

merged 1 commit into from
Oct 23, 2023

Conversation

tmccombs
Copy link
Collaborator

Supersedes: #1230

@tmccombs
Copy link
Collaborator Author

Should I soften the language to use "in general" since there are cases when it is sorted?

sharkdp
sharkdp approved these changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sharkdp sharkdp merged commit c6fcdbe into sharkdp:master Oct 23, 2023
15 checks passed
@sharkdp
Copy link
Owner

sharkdp commented Oct 23, 2023

Should I soften the language to use "in general" since there are cases when it is sorted?

The only case I have in mind relies on timing? (if results come in faster than X milliseconds, we sort them before printing/using in exec)

And relying on timing is certainly not a good idea, so I think your advise is good.

@tmccombs tmccombs deleted the exec-docs branch October 23, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmccombs @sharkdp