Use threads to speed up connectivity check #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a ThreadPoolExecutor to send the requests to embed.gog.com and auth.gog.com from separate threads. As these threads do I/O-bound work, they will hand the GIL back while waiting for responses, which speeds up the work as opposed to sending the requests and waiting for the responses sequentially.
|
Nice, that makes more of a difference than I was expecting. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a ThreadPoolExecutor to the api.can_connect function in order to send the requests to embed.gog.com and auth.gog.com from separate threads. This lowers the worst case execution time from 10 seconds to 5 seconds, which is noticeable on slow connections.
Checklist