Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Examples Collection to be easier to maintain and invokable from Xamarin App #149

Open
tthiery opened this issue Mar 30, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tthiery
Copy link
Member

tthiery commented Mar 30, 2021

No description provided.

@tthiery tthiery added the enhancement New feature or request label Mar 30, 2021
@tthiery tthiery added this to the v4.0 (breaking) milestone Mar 30, 2021
@tthiery tthiery self-assigned this Mar 30, 2021
@tthiery
Copy link
Member Author

tthiery commented Apr 30, 2021

@Berdsen I changed some code recently of the example code base ... is that more to your liking or what can we do to improve the situation there?

@tthiery tthiery removed this from the v4.0 (breaking) milestone May 8, 2021
@Berdsen
Copy link
Contributor

Berdsen commented May 13, 2021

@tthiery
That looks a bit tricky to bring the examples into two different solutions.
Perhaps we could:

  • exclude the test solution in an own repository
  • include it in powered-up and example-xamarin repos as a git submodule
  • extract an interface out of the BaseExample class
  • and have then the own implementations in separate folders or solutions

Might be a good solution for having just one example code base

@tthiery
Copy link
Member Author

tthiery commented May 14, 2021

I will factor the base application into the Program.cs (basically removing this OO 💩). If you like, I just create another .dll without any host code, hosting exclusively the examples.

Would that help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants