GUI legend: add set_log_mode method with boolean argument

Simplifies some calling code.
shawnlaffan · Dec 30, 2023 · f538103 · f538103
1 parent 0702f94
commit f538103
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/Biodiverse/GUI/Legend.pm b/lib/Biodiverse/GUI/Legend.pm
@@ -1160,6 +1160,13 @@ sub set_text_marks_for_labels {
     return;
 }
 
+sub set_log_mode {
+    croak "boolean arg not passed"
+      if @_ < 2;
+    my ($self, $bool) = @_;
+
+    return $self->{log_mode} = $bool ? 1 : 0;
+}
 
 sub set_log_mode_on {
     my ($self) = @_;

diff --git a/lib/Biodiverse/GUI/Tabs/Spatial.pm b/lib/Biodiverse/GUI/Tabs/Spatial.pm
@@ -1690,12 +1690,7 @@ sub colour_branches_on_dendrogram {
     );
 
     my $log_check_box = $self->{xmlPage}->get_object('menuitem_spatial_tree_log_scale');
-    if ($log_check_box->get_active) {
-        $legend->set_log_mode_on;
-    }
-    else {
-        $legend->set_log_mode_off;
-    }
+    $legend->set_log_mode($log_check_box->get_active);
 
     my $flip_check_box = $self->{xmlPage}->get_object('menuitem_spatial_tree_colour_stretch_flip_mode');
     $legend->set_invert_colours ($flip_check_box->get_active);