-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Richness estimation 2024 #918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faster::Maths allows a substantial speed-up (7-30%) of arithmetic code, of which there is a lot in this module. It currently segfaults in some circumstances so lexically disable it as needed. This has been reported to its RT queue. Also avoid some looping and memory usage in the ACE and ICE variance calculations.
No need to iterate over the same sets twice.
The former is now a wrapper around the latter, the difference being which differential method is called.
Marginally faster and uses a mite less memory.
No need to pass all the args onwards when we only need four.
… args No need to pass them through calc_abc first.
This is re-used many times in the calculations
This is re-used many times in the calculations
This is re-used many times in the calculations
This is re-used many times in the calculations
Add class details and default colours to the metadata.
An empty array is expected for the bounds, rather than undef.
There is no need for the number of classes in the sub name as they are all from the same sets. It is just that some sets have less colours in total. And add all the colorbrewer qualitative palettes while we are here.
These are not used in these packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and optimisations for the richness estimation indices,
including displaying the metadata as categories in the GUI.
And a few other minor things.