use for_list feature, require perl 5.36 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to assign a variable using a ternary. We only use it once, and booleans in numeric context do the same thing as the ternary did anyway.
This is faster than iterating over keys and then getting the values.
Needed for for_list feature
A small speedup that will be useful under randomisations
`use experimental` instead of the two step `use feature; no warnings` idiom
more CI stuff Appveyor: enable BD tests GH: cleanup commented code GH CI windows cache more appveyoring GH CI: quieter windows more appveyor shenanigans GH CI windows: cache ./local shogo82148/actions-setup-perl sends modules there, overriding the env settings CI appveyor full build again CI appveyor partial build to trigger cache CI probing GH CI: windows use strawberry GH CI: use shogo82148/actions-setup-perl on windows GH CI: use perl 5.40 on windows GH CI: refresh windows cache GH CI: cache and checkout actions to v4 CI: appveyor to perl 5.38
It seems not to be stable on some systems.
Even the "no faster::Maths" triggers checks for it being installed.
Simplify the setup in the process. (Tested and debugged on a separate branch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for_list feature was introduced in Perl 5.36 and declared stable in 5.40.
It provides faster looping over hashes in cases where one otherwise iterates over keys and then accesses the values.
The update to 5.36 required changes to the CI configs on Windows.
This PR also removes Faster::Maths as stability issues arose when updating the CI. F::M is nice to have but not essential, and requires careful handling anyway given known issues.