Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf/ahash replace #39

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Perf/ahash replace #39

merged 3 commits into from
Apr 29, 2024

Conversation

shenxiangzhuang
Copy link
Owner

@shenxiangzhuang shenxiangzhuang commented Apr 29, 2024

Summary by CodeRabbit

  • New Features
    • Integrated the ahash library for enhanced performance in ngram counts computation.

@shenxiangzhuang shenxiangzhuang added the enhancement New feature or request label Apr 29, 2024
@shenxiangzhuang shenxiangzhuang added this to the 0.1.2 milestone Apr 29, 2024
@shenxiangzhuang shenxiangzhuang self-assigned this Apr 29, 2024
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

The update boosts performance by leveraging the ahash crate, enhancing hash map efficiency. Specifically, the BleuScore struct in src/bleu.rs now utilizes AHashMap from ahash for faster n-gram computations. No changes affect public or exported entities beyond these modifications.

Changes

File Summary
CHANGELOG.md, Cargo.toml Added ahash dependency for improved performance.
src/bleu.rs Replaced HashMap with AHashMap for n-gram counts.

🐇✨
In the code's woven tapestry,
Threads of HashMap gently pull free.
With a hop and a skip, AHashMap slips in,
Swift as the wind, let the races begin!
🚀🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d71a5cd and 7c0113f.
Files selected for processing (1)
  • src/bleu.rs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/bleu.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 29, 2024

🐰Bencher

ReportMon, April 29, 2024 at 10:18:01 UTC
Projectbleuscore
Branchperf/ahash_replace
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
bleu::benchmark::bench_bleu➖ (view plot)288,488.00
ngram::benchmark::bench_ngram➖ (view plot)47,745.00
tokenizer::benchmark::bench_tokenizer➖ (view plot)15,826.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (131ca43) to head (7c0113f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files           4        4           
  Lines         308      308           
=======================================
  Hits          254      254           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md Show resolved Hide resolved
@shenxiangzhuang shenxiangzhuang merged commit c722ce9 into master Apr 29, 2024
14 checks passed
@shenxiangzhuang shenxiangzhuang deleted the perf/ahash_replace branch April 29, 2024 10:19
This was referenced Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant