-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable adapter #47
disable adapter #47
Conversation
Warning Rate Limit Exceeded@shenxiangzhuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 55 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates remove the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 4 4
Lines 368 368
=======================================
Hits 313 313
Misses 55 55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
.github/workflows/bench_pr.yml (1)
Line range hint
19-29
: Avoid using${{...}}
forgithub
context data directly in therun:
step to prevent potential code injection attacks. Instead, use intermediate environment variables.- name: Track PR Benchmarks with Bencher env: BENCHER_API_TOKEN: ${{ secrets.BENCHER_API_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_HEAD_REF: ${{ github.head_ref }} GITHUB_BASE_REF: ${{ github.base_ref }} GITHUB_BASE_SHA: ${{ github.event.pull_request.base.sha }} run: | bencher run \ --project bleuscore \ --token "$BENCHER_API_TOKEN" \ --branch "$GITHUB_HEAD_REF" \ --branch-start-point "$GITHUB_BASE_REF" \ --branch-start-point-hash "$GITHUB_BASE_SHA" \ --testbed ubuntu-latest \ --err \ --github-actions "$GITHUB_TOKEN" \ cargo bench --all
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/bench_base.yml (1 hunks)
- .github/workflows/bench_pr.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/bench_base.yml
Additional comments not posted (1)
.github/workflows/bench_pr.yml (1)
Line range hint
19-29
: The--adapter rust
option has been removed from thecargo bench --all
command. Ensure that this change aligns with the intended benchmarking setup and that no functionality is lost.
Summary by CodeRabbit