Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable adapter #47

Closed
wants to merge 5 commits into from
Closed

disable adapter #47

wants to merge 5 commits into from

Conversation

shenxiangzhuang
Copy link
Owner

@shenxiangzhuang shenxiangzhuang commented May 14, 2024

Summary by CodeRabbit

  • Chores
    • Updated workflow configurations to remove an unnecessary option for benchmarking tasks.

@shenxiangzhuang shenxiangzhuang self-assigned this May 14, 2024
Copy link
Contributor

coderabbitai bot commented May 14, 2024

Warning

Rate Limit Exceeded

@shenxiangzhuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 426777e and f422afe.

Walkthrough

The updates remove the --adapter rust option from the cargo bench --all command in two GitHub Actions workflow files, simplifying the benchmarking process for both base and pull request workflows.

Changes

Files Change Summary
.github/workflows/bench_base.yml Removed --adapter rust option from cargo bench --all command.
.github/workflows/bench_pr.yml Removed --adapter rust option from cargo bench --all command.

🐰
In the land of code where benchmarks run,
We simplified the scripts, oh what fun!
No more adapters, just pure and neat,
Our workflows now are quite the feat.
With every change, we hop ahead,
Making sure our code is well-bred.
🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (97da600) to head (f422afe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files           4        4           
  Lines         368      368           
=======================================
  Hits          313      313           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
.github/workflows/bench_pr.yml (1)

Line range hint 19-29: Avoid using ${{...}} for github context data directly in the run: step to prevent potential code injection attacks. Instead, use intermediate environment variables.

      - name: Track PR Benchmarks with Bencher
        env:
          BENCHER_API_TOKEN: ${{ secrets.BENCHER_API_TOKEN }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_HEAD_REF: ${{ github.head_ref }}
          GITHUB_BASE_REF: ${{ github.base_ref }}
          GITHUB_BASE_SHA: ${{ github.event.pull_request.base.sha }}
        run: |
          bencher run \
          --project bleuscore \
          --token "$BENCHER_API_TOKEN" \
          --branch "$GITHUB_HEAD_REF" \
          --branch-start-point "$GITHUB_BASE_REF" \
          --branch-start-point-hash "$GITHUB_BASE_SHA" \
          --testbed ubuntu-latest \
          --err \
          --github-actions "$GITHUB_TOKEN" \
          cargo bench --all
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 97da600 and 426777e.
Files selected for processing (2)
  • .github/workflows/bench_base.yml (1 hunks)
  • .github/workflows/bench_pr.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/bench_base.yml
Additional comments not posted (1)
.github/workflows/bench_pr.yml (1)

Line range hint 19-29: The --adapter rust option has been removed from the cargo bench --all command. Ensure that this change aligns with the intended benchmarking setup and that no functionality is lost.

@shenxiangzhuang shenxiangzhuang deleted the fix/ci branch July 22, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant