Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Desktop does not respect KDE Plasma "Keyboard accelerators visibility" setting #1059

Closed
Tiagoquix opened this issue May 2, 2024 · 2 comments

Comments

@Tiagoquix
Copy link

The problem

Hi there.

The app does not respect KDE Plasma's "Keyboard accelerators visibility" setting (letter underlines).

image

image

Is there a fix available for this? Thanks in advance.

Release version

3.3.12-linux2 (x64)

Operating system

Fedora Linux 40 KDE

Steps to reproduce the behavior

No response

Log files

No response

Screenshots

No response

Additional context

No response

@shiftkey
Copy link
Owner

The app itself is built using Electron, so it's support of window manager settings is currently limited. It's been a while since I've looked into the Chromium internals to see how it detects things like light/dark mode and it may not be possible to easily check this for different window managers.

As this would likely require contributions to Chromium or Electron to detect this setting I'm going to tag this as an upstream issue but I don't have plans to support this.

@Tiagoquix
Copy link
Author

The issue has been fixed at some point with some update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants