-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTK 4 variant of Greybird-dark #341
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1 @@ | |||
../../light/gtk-4.0/Gemfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
@@ -0,0 +1 @@ | |||
../../light/gtk-4.0/_common.scss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commas in function parameters should be followed by one space
@@ -0,0 +1 @@ | |||
../../light/gtk-4.0/gtk-contained-dark.scss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
@@ -0,0 +1 @@ | |||
../../light/gtk-4.0/gtk-dark.scss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
@@ -0,0 +1 @@ | |||
../../light/gtk-4.0/gtk.scss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
Thanks, but fail to build:
|
27c472c
to
473c72c
Compare
@import 'colors'; | ||
@import 'drawing'; | ||
@import 'common'; | ||
@import 'colors-public'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
|
||
@import 'colors'; | ||
@import 'drawing'; | ||
@import 'common'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
$variant: 'dark'; | ||
|
||
@import 'colors'; | ||
@import 'drawing'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
|
||
$variant: 'dark'; | ||
|
||
@import 'colors'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
// you need a subtle shade | ||
// - if you need to inverse a color function use the @if directive to match for dark $variant | ||
|
||
$variant: 'dark'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
Any difference now? The changes should match the GTK 3 theme, unless I overlooked something. |
No, same errors. |
|
It uses symlinks in the same way as the GTK 3 theme, although I don't understand why they are failing. Everything builds correctly on my end. Does the master branch work fine for you? |
Master build ok for me.
|
Probably you have set |
473c72c
to
278bcc1
Compare
It was not set, but I set it to true just in case. It's a symlink according to GitHub, and also when cloning my branch: |
Sorry, FreeBSD~s patch does not handle symlinks from git patch files. Now error changed:
|
Did you symlink the assets directory? |
Fixes https://forum.xfce.org/viewtopic.php?pid=73009