Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Remap of the Ranger #2034

Merged
merged 34 commits into from
Aug 20, 2023
Merged

Conversation

Latentish
Copy link
Member

@Latentish Latentish commented Jun 9, 2023

About The Pull Request

The old ranger is just about a year old. This totally remaps this ship and rebalances it for our current standards.
rangerpng
2023-08-19 12 35 04

This is good for the game because it replaces a year old ship with something that's more up to par with our standards.

Why It's Good For The Game

Ship upkeep and maintaining our maps is a good thing. Plus the old ranger had a bunch of old snowflaked code that was a bandaid fix for the ship access system not existing yet. (It unsnowflakes it).

Changelog

🆑
tweak: Remaps the Ranger-class
/:cl:

-Adds a basis for the remap
still gotta make it pretty
-Removes all non lp jobs and adds an assistant.
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Jun 9, 2023
-Adds firelocks
-Adds a bit of precharge to the SMES
-Gets the ship to actually spawn (ports are still fucked)

Still needs fire alarms
-Changes some flooring in the ai chamber
-Adds missing piping.
@Latentish
Copy link
Member Author

Latentish commented Jun 9, 2023

ToDO:

  • Fire Alarms
  • Cameras
  • Holopads
  • Access
  • Ripping out old code
  • Fixing docking ports
  • Decals

@BarteG44
Copy link
Contributor

BarteG44 commented Jun 9, 2023

the modern railing handrails can be set to have a custom color
image

Ship still turns, but it flies in the right direction at least.
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 11, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

-Adds some decaling
-Adds more ship
-Gives the medic some gear
-Adds more decal work
- Removes the snowflaked ranger accesses
- Trims the mission list
- Adds minor details to the ship
- Removes the commissioner job
@github-actions github-actions bot added the Code change Watch something violently break. label Jun 25, 2023
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 25, 2023
-Almost forgot these
@Latentish Latentish marked this pull request as ready for review June 25, 2023 00:46
@Latentish Latentish requested a review from a team as a code owner June 25, 2023 00:46
mINOR DECAL FIX!!!!
-Redoes decals
-adds an exosuit fab circuit to the cyborg pile
-adds a second boris
-gives them more air for the emergency entrance/exit
-one of last commit's changes didn't make it into the commit
The engines stop air now!!!!!!!!!!!!
@Latentish
Copy link
Member Author

rangernewest
2023-06-27 02 29 30
The group pissing picture took 8 minutes to take you get these in a comment this time.

Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in here has changed the default captain outfit to be the LP lieutenant outfit.

@Latentish
Copy link
Member Author

Something in here has changed the default captain outfit to be the LP lieutenant outfit.

I don't see anything in the code that would imply this. Could you give me more specifics? Do you mean outfit datum? Outfit as in clothes? Did you see this on tm? Was it a full outfit swap?

@Latentish Latentish requested review from a team and Erikafox August 12, 2023 13:05
-adds well needed commas
-Shiplinters
@Latentish Latentish marked this pull request as ready for review August 12, 2023 13:17
@Latentish
Copy link
Member Author

hokay it's ready for the testering crew to look at its testerability

@Sly9sky
Copy link

Sly9sky commented Aug 12, 2023

Mainly with what I've seen so far, the Medical Specialist should get a stretcher if they don't have one already, and the bridge doesn't start out with a helm console, to which I think the foremost console should be replaced with one.

-Fixes missing pipes
-Adds the helm =)
-gives the medic roller beds
-removes a stray closet
-Adds wiring under the engines and prechargers
-happy maintainer chwismas
@Latentish
Copy link
Member Author

this int test is on some shit

@Latentish
Copy link
Member Author

image
This is neither from my map, nor from this latest commit. There is no "library" area on the ranger.

@Erikafox
Copy link
Contributor

image
the equipment room needs decals, the other room still has the Bad Decal Pattern

Latentish and others added 4 commits August 17, 2023 20:49
-Swaps some consoles for the combo icons.
-Adds some floor decals to the engineer rooms.
-The silliness is gone 😭
-38 hunting was never meant to be apparently.
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que the crazy frog music

@spockye spockye enabled auto-merge August 19, 2023 20:19
@spockye spockye requested review from Erikafox and removed request for Erikafox August 19, 2023 20:55
@spockye spockye added this pull request to the merge queue Aug 20, 2023
Merged via the queue into shiptest-ss13:master with commit 22bd762 Aug 20, 2023
10 checks passed
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
The old ranger is just about a year old. This totally remaps this ship
and rebalances it for our current standards.

![rangerpng](https://github.com/shiptest-ss13/Shiptest/assets/55075747/1290c0e9-5efb-4235-b047-a8993466f5ca)
![2023-08-19 12 35
04](https://github.com/shiptest-ss13/Shiptest/assets/55075747/acfb106e-b770-4f9a-8f76-bdbcb3dee6ff)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
This is good for the game because it replaces a year old ship with
something that's more up to par with our standards.
## Why It's Good For The Game
Ship upkeep and maintaining our maps is a good thing. Plus the old
ranger had a bunch of old snowflaked code that was a bandaid fix for the
ship access system not existing yet. (It unsnowflakes it).
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Remaps the Ranger-class
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: spockye <79304582+spockye@users.noreply.github.com>
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants