Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Most Serene Solar Confederation's Most Serene Solar Starship, The Chronicle #2074

Merged
merged 31 commits into from
Jul 11, 2023

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Jun 15, 2023

About The Pull Request

2023-06-15 14 00 08
2023-06-15 14 00 10

It's The Solgov Ship. It uses The Solgov Content.

More specifically it's a engineering / intelligence ship, kind of like a mildly larger kansatsu. A lot of content relating to sensors still doesn't exist, but they've got the gear and equipment to get the authentic Solgov Experience. This includes, but is not limited to: Energy halbreds, excessive amounts of blue and gold, paperwork, and holopads.

Crew consists of
1 Captain
1 Overseer
2 Field Engineers
1 Sonnensoldner
2 Ship Engineers
1 Scribe
For a total of 8 crew.

Why It's Good For The Game

Solgov content

Changelog

🆑
add: table mounted intercoms now exist
add: The Chronicle Class, a Real Solgov Ship, is now in game
/:cl:

@Erikafox Erikafox requested review from a team as code owners June 15, 2023 21:02
@github-actions github-actions bot added Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. labels Jun 15, 2023
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

wild wire

image

this wall is Diagonal (looks somewhat bad ingame)
also get scrubbed

image

double beds have directional sprites
also replace it with the maints version please :)

@Zevotech
Copy link
Contributor

image
me in the shower of the Chronicle

Copy link
Contributor

@Apogee-dev Apogee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something of an excess of spare headsets here, and so far they tend to end up in the hands of the regular crew. Personally I would remove the spare bowman headsets for the officers so they just have the ones they spawn with, and just leave a bowman headset for the Sonnensoldner since they actually could use the ear protection.

Also, you may want to consider making this adminspawn only, if only for the initial faction rollout.

@spockye
Copy link
Contributor

spockye commented Jun 17, 2023

image

wuh woh

image

might want to move the APC somewhere else. it goes over the reciver, and is kinda locked away

image

lockers here on purpouse? looks a bit weird

image

diag wall

Field engineer is a "miner", which is a bit... confusing. perhaps try to rename them?

@RuneQuesteER
Copy link

Lobster ship

@spockye spockye self-requested a review July 5, 2023 18:18
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im a huge fan of this ship!
tried it ingame, and it works well

Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship good moment.

Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need tags and a description.

@spockye
Copy link
Contributor

spockye commented Jul 11, 2023

:3

@spockye spockye enabled auto-merge July 11, 2023 18:48
@spockye spockye requested a review from Latentish July 11, 2023 21:20
@spockye spockye added this pull request to the merge queue Jul 11, 2023
Merged via the queue into shiptest-ss13:master with commit 7171e23 Jul 11, 2023
10 checks passed
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
… Chronicle (shiptest-ss13#2074)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
![2023-06-15 14 00
08](https://github.com/shiptest-ss13/Shiptest/assets/94164348/629b864a-e00f-481e-b9b9-03567d13d5e8)
![2023-06-15 14 00
10](https://github.com/shiptest-ss13/Shiptest/assets/94164348/825bb8b3-ab00-4643-9166-407a44145717)

It's The Solgov Ship. It uses The Solgov Content. 

More specifically it's a engineering / intelligence ship, kind of like a
mildly larger kansatsu. A lot of content relating to sensors still
doesn't exist, but they've got the gear and equipment to get the
authentic Solgov Experience. This includes, but is not limited to:
Energy halbreds, excessive amounts of blue and gold, paperwork, and
holopads.

Crew consists of
1 Captain
1 Overseer
2 Field Engineers
1 Sonnensoldner
2 Ship Engineers
1 Scribe
For a total of 8 crew.


## Why It's Good For The Game
Solgov content
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: table mounted intercoms now exist
add: The Chronicle Class, a Real Solgov Ship, is now in game
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
… Chronicle (shiptest-ss13#2074)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
![2023-06-15 14 00
08](https://github.com/shiptest-ss13/Shiptest/assets/94164348/629b864a-e00f-481e-b9b9-03567d13d5e8)
![2023-06-15 14 00
10](https://github.com/shiptest-ss13/Shiptest/assets/94164348/825bb8b3-ab00-4643-9166-407a44145717)

It's The Solgov Ship. It uses The Solgov Content. 

More specifically it's a engineering / intelligence ship, kind of like a
mildly larger kansatsu. A lot of content relating to sensors still
doesn't exist, but they've got the gear and equipment to get the
authentic Solgov Experience. This includes, but is not limited to:
Energy halbreds, excessive amounts of blue and gold, paperwork, and
holopads.

Crew consists of
1 Captain
1 Overseer
2 Field Engineers
1 Sonnensoldner
2 Ship Engineers
1 Scribe
For a total of 8 crew.


## Why It's Good For The Game
Solgov content
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: table mounted intercoms now exist
add: The Chronicle Class, a Real Solgov Ship, is now in game
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
@Erikafox Erikafox deleted the solgov-shippu branch October 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants