Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valor-Class Field Care Crusier #2144

Merged
merged 58 commits into from
Feb 4, 2024
Merged

Conversation

meemofcourse
Copy link
Contributor

@meemofcourse meemofcourse commented Jul 8, 2023

About The Pull Request

valor3
2023-07-07 21 37 25

Did something go terribly wrong? Do you have wounded? Are you wounded? Do you have money? You're in luck! The Valor-Class is Inteq's medical component of their fleet, and provides a great service for a meager* fee! Armed with a tiny patient recovery vessel and spacious medical facilities, this flying field hospital is ready to provide rapid tactical care for all that ails you (beyond the mental scarring of losing all your friends). This comes at the expense of relying on other ships for food, research or armaments.

It is staffed by:

  • 1 Vanguard
  • 1 Honorable Corpsman
  • 3 Corpsmen
  • 2 Enforcers
  • 2 Recruits

Why It's Good For The Game

it's the inteq medical ship it uses the inteq content

Changelog

🆑
add: Valor-Class Field Care Crusier
add: Haste-Class Ambulance
/:cl:

meemofcourse and others added 6 commits July 7, 2023 05:10
-config changes
-map changes
-wires
-posters
-sinks
-changes floor type of landing spot and engine pods
-maybe a lightbulb or seven
-deletes accidental decal in cryo
@meemofcourse meemofcourse requested a review from a team as a code owner July 8, 2023 01:53
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jul 8, 2023
meemofcourse and others added 2 commits July 7, 2023 22:08
-wires storage bay
-fixes piping
Copy link
Contributor

@spockye spockye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

wild decal

image

unconnected atmos. Scrubbers need a exhaust

image

holofields need to be connected to the powernet

image

airlocks dont work if you dont give them a way to cycle air

image

a lot of rooms are missing air alarms

image

a lot of doors seem to be missing firelocks
ALSO not seeing any fire alarms!

image

flooring under window

image

two helmets
one suit

image

accidental glass? (already a full stack under the metal)

image

i'd say make these walls non-diagonal

image

missing corner decal (also that wall is also diagonal. wont really fit with the decalling)

-firelocks
-alarms
-injector
-airlock should work. probably
-non-diagonal walls
-holofield should work
Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StrongDMM_487dSP5iRP
If you're putting the /loaded mount type, they don't need a second defib.
StrongDMM_KXe9xIudZq
clean your wires up here, make it more organic

-wires
-no more defib mount
Copy link
Contributor

@Apogee-dev Apogee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just replace all of your walls except for external ones that you specifically want angled with the nodiag variant. It'll save a lot of headaches.

Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docking port on the lower half means that the subshuttle will not land in the bay.

I've heard issues about the prechargers on the subshuttle, make sure they're wired properly

meemofcourse and others added 3 commits July 14, 2023 15:40
-nondiag walls
-removes airlock dock
-the prechargers for the subshuttle were not wired
Copy link
Contributor

@Apogee-dev Apogee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-The holofields and blast door on the ambulance need to be at the edge of the ship so patients don't need to cross a tile of exposed space to board it when it's docked to the exterior of a ship.

-Please replace the "public" airlocks with the public/glass variant, or use green airlocks for rooms like dorms and cryo.

-Just use grunge airlocks or other variants instead of hatch airlocks inside the nacelles; it doesn't make sense for crew to have to crawl through hatches when moving e.g. from the medical treatment center to the recovery room. The same applies for the main hallways into the nacelles; they're presumably high-traffic areas. You can use maint hatches instead of yellow engineering airlocks for the thruster rooms.

-All of the hallways into the wings are only 1 tile wide. This can cause traffic jams, especially when dragging bulky objects. Either make both 2 tiles wide or make the larger ones 3 passable tiles wide. Yes, this will mean eliminating the lattices over elevator floors that you like, but there's no real way around that.

-You can probably use white tiles in the medical wing where you currently have grey ones. Both dark and white work for medical areas imo but grey ones really don't.

-Remember to give the med beds medical bedsheets.

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
Copy link
Contributor

@Apogee-dev Apogee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to replace all of the walls except the exterior corners you actually want smoothed with the nodiag variant. You have a few weird internal corners that end up smoothing when they should not, like at the security desk.

You have some misplaced corner decals in the cargo loading areas.

Remember to check the floor tiles under your doors and give them a good texture and potentially decals (see Colossus and Talos for reference), a few doors still have default grey tiles and they look more than a little off.

Consider varying the floor tiles in cargo. Note how both the Colossus and Talos use a different floor texture in the "walkable" parts of cargo compared to the cargo storage areas.

Also please edit the ambulance as mentioned in the previous review and depicted in the image below:
example

-less monoflooring in cargo
-changes some decals in the map
-cuts off one tile from the ambulance
-deletes wild decals
@Erikafox Erikafox requested a review from Apogee-dev July 30, 2023 23:02
@spockye spockye self-requested a review August 18, 2023 09:31
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jan 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 18, 2024
Copy link
Contributor

@Zevotech Zevotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You Have Passed The Test! This should be TM'ed at least once for player feedback and then merged. Good Ship.

@Apogee-dev
Copy link
Contributor

You should probably put a comms relay on this thing like the one the Colossus has, so it'll link up to a Talos if one is present. Past experience with other comms ships (the Ranger) indicated that relying on the ship to install comms on friendlies means comms will either never get set up or just get set up for everybody regardless of faction.

@Zorazi-Teo-Daedalus
Copy link

I'm not sure what the point of giving a medical techfab without an RND console is but I'm not a fan of it given most other medical ships have it save for like the Paracelsus. Aside from that, no rezadone feels weird on a hospital ship, not that rezadone is hard to acquire anyway, but rather it just feels like something a hospital craft should start with.

@Apogee-dev
Copy link
Contributor

I'm not sure what the point of giving a medical techfab without an RND console is but I'm not a fan of it given most other medical ships have it save for like the Paracelsus. Aside from that, no rezadone feels weird on a hospital ship, not that rezadone is hard to acquire anyway, but rather it just feels like something a hospital craft should start with.

aegis, asclepius, and li tieguai- in other words, every medship except the box and paracelsus- also don't come with rezadone. and that's because they're both meant to start with an excellent stock of medicine.

@thgvr
Copy link
Member

thgvr commented Feb 4, 2024

ship ?

@thgvr thgvr added this pull request to the merge queue Feb 4, 2024
@thgvr thgvr added Ship Ship Ship successfully tested. and removed Ship labels Feb 4, 2024
Merged via the queue into shiptest-ss13:master with commit 07825a4 Feb 4, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Feb 7, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

![valor3](https://cdn.discordapp.com/attachments/1021926309611442246/1197668934795665499/valor.png?ex=65bc1b1d&is=65a9a61d&hm=71fadf813dda96fae87b6842e5bb8961bfd014a0f4e631513ca46e7d3e20c13d&)
![2023-07-07 21 37
25](https://cdn.discordapp.com/attachments/1021926309611442246/1197667812886458448/image.png?ex=65bc1a12&is=65a9a512&hm=988070177c49e8515f033320c8850b8d7f28dff1e10d799e569f3cf39ae3c3f8&)

Did something go terribly wrong? Do you have wounded? Are _you_ wounded?
Do you have money? You're in luck! The Valor-Class is Inteq's medical
component of their fleet, and provides a great service for a meager*
fee! Armed with a tiny patient recovery vessel and spacious medical
facilities, this flying field hospital is ready to provide rapid
tactical care for all that ails you (beyond the mental scarring of
losing all your friends). This comes at the expense of relying on other
ships for food, research or armaments.

It is staffed by:
* 1 Vanguard
* 1 Honorable Corpsman
* 3 Corpsmen
* 2 Enforcers
* 2 Recruits

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

it's the inteq medical ship it uses the inteq content

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: Valor-Class Field Care Crusier
add: Haste-Class Ambulance
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: meem <75212565+meemofcourse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants