Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port ckey in deadchat from yogs #2187

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

GenericDM
Copy link
Member

About The Pull Request

ports yogstation13/Yogstation#4134

Why It's Good For The Game

helps people find each other

Changelog

🆑
add: adds a preference to show your username in deadchat
/:cl:

GenericDM and others added 5 commits July 20, 2023 23:18
port ancient shitcode from yogs that i did 5 years ago in yogstation13/Yogstation#4134

Signed-off-by: GenericDM <34109002+GenericDM@users.noreply.github.com>
don't make the same mistake i made 5 years ago

Signed-off-by: GenericDM <34109002+GenericDM@users.noreply.github.com>
Signed-off-by: GenericDM <34109002+GenericDM@users.noreply.github.com>
Signed-off-by: GenericDM <34109002+GenericDM@users.noreply.github.com>
@github-actions github-actions bot added the Code change Watch something violently break. label Jul 21, 2023
@thgvr
Copy link
Member

thgvr commented Jul 21, 2023

i think this sucks

@GenericDM
Copy link
Member Author

yogstation13/Yogstation#4134 (comment)
yogstation13/Yogstation#4134 (comment)
I think it's a handy way to find people and make friends OOC.
Anyone that's uncomfortable with their username being linked back to them can just keep it off.
I quite enjoy shooting the shit after round-end with people I interacted with IC.

@Draggeru
Copy link
Contributor

Draggeru commented Jul 21, 2023

-Edit, nevermind its apparently already toggleable

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Aug 3, 2023
Merged via the queue into shiptest-ss13:master with commit 9cfff30 Aug 3, 2023
10 checks passed
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports yogstation13/Yogstation#4134

## Why It's Good For The Game

helps people find each other

## Changelog

:cl:
add: adds a preference to show your username in deadchat
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: GenericDM <34109002+GenericDM@users.noreply.github.com>
Co-authored-by: Generic DM <genericdm.dm@gmail.com>
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports yogstation13/Yogstation#4134

## Why It's Good For The Game

helps people find each other

## Changelog

:cl:
add: adds a preference to show your username in deadchat
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: GenericDM <34109002+GenericDM@users.noreply.github.com>
Co-authored-by: Generic DM <genericdm.dm@gmail.com>
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants