-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitizes syndicate headsets in outfits #2189
Merged
MarkSuckerberg
merged 1 commit into
shiptest-ss13:master
from
Apogee-dev:syndie-headset-sanity
Jul 24, 2023
Merged
Sanitizes syndicate headsets in outfits #2189
MarkSuckerberg
merged 1 commit into
shiptest-ss13:master
from
Apogee-dev:syndie-headset-sanity
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception for the twinkleshine. unfortunately.
shiptest-server
pushed a commit
that referenced
this pull request
Jul 24, 2023
MarkSuckerberg
pushed a commit
to MarkSuckerberg/Shiptest
that referenced
this pull request
Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Removes Syndie headsets from Syndie job outfits that are not officers or Twinkleshine crew, bringing the Syndie headset distribution in line with other factions. Does not touch the maps themselves, so if spare headsets need to be removed (and they should) this will have to be done separately. ## Why It's Good For The Game Faction radio channels are intended to function as something of a faction-exclusive wideband, not a common channel for every member of the faction to flood with minutiae. This is the same reason ships with pre-built comms do not relay the common channel across the sector- Comms spam sucks. ## Changelog :cl: balance: Removed Syndie headsets from non-officer jobs for parity with other factions /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MarkSuckerberg
pushed a commit
to MarkSuckerberg/Shiptest
that referenced
this pull request
Aug 11, 2023
MarkSuckerberg
pushed a commit
to MarkSuckerberg/Shiptest
that referenced
this pull request
Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Removes Syndie headsets from Syndie job outfits that are not officers or Twinkleshine crew, bringing the Syndie headset distribution in line with other factions. Does not touch the maps themselves, so if spare headsets need to be removed (and they should) this will have to be done separately. ## Why It's Good For The Game Faction radio channels are intended to function as something of a faction-exclusive wideband, not a common channel for every member of the faction to flood with minutiae. This is the same reason ships with pre-built comms do not relay the common channel across the sector- Comms spam sucks. ## Changelog :cl: balance: Removed Syndie headsets from non-officer jobs for parity with other factions /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MarkSuckerberg
pushed a commit
to MarkSuckerberg/Shiptest
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Removes Syndie headsets from Syndie job outfits that are not officers or Twinkleshine crew, bringing the Syndie headset distribution in line with other factions. Does not touch the maps themselves, so if spare headsets need to be removed (and they should) this will have to be done separately.
Why It's Good For The Game
Faction radio channels are intended to function as something of a faction-exclusive wideband, not a common channel for every member of the faction to flood with minutiae. This is the same reason ships with pre-built comms do not relay the common channel across the sector- Comms spam sucks.
Changelog
🆑
balance: Removed Syndie headsets from non-officer jobs for parity with other factions
/:cl: