Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes Chemistry Dispenser Parts #2468

Closed
wants to merge 3 commits into from

Conversation

Geoengi
Copy link
Contributor

@Geoengi Geoengi commented Nov 10, 2023

About The Pull Request

Gives every chemistry dispenser circuit board subtype the same required parts while removing the NODECONSTRUCT flag from the few that had it. Leaves the abductor chemistry dispenser mostly untouched as realistically nobody will get their hands on it and that it should have upgraded part requirements given the technology. Gives the mutagen dispenser a circuit board as before it would deconstruct and reconstruct into a normal, full-listed chemistry dispenser.

Why It's Good For The Game

Allows mechanic renovators to remove the Komodo's bar machines without pissing off the entire crew by destroying the infinite well of drinks, while also not giving them overpowered parts from the outset. Bug fix good. Addresses half of #2348.

Changelog

🆑
balance: Almost every chemistry dispenser subtype now has a standardized part list.
tweak: All chemistry dispenser subtypes are now deconstructable.
fix: The mutagen dispenser now has a circuit board.
/:cl:

Signed-off-by: Geoengi <139566513+Geoengi@users.noreply.github.com>
Signed-off-by: Geoengi <139566513+Geoengi@users.noreply.github.com>
@github-actions github-actions bot added the Code change Watch something violently break. label Nov 10, 2023
Signed-off-by: Geoengi <139566513+Geoengi@users.noreply.github.com>
Copy link
Contributor

@Erikafox Erikafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 from me. These are mapping subtypes and they would benefit more from construction methods just being removed.

/obj/item/stack/sheet/glass = 1,
/obj/item/stock_parts/cell/bluespace = 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frankly I don't know why this has an assembly type given that it's effectively a mapping subtype

/obj/item/stack/sheet/glass = 1,
/obj/item/stock_parts/cell/bluespace = 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this one

@thgvr
Copy link
Member

thgvr commented Nov 13, 2023

The issue with those dispensers on the Komodo is they are special mapping subtypes. The map needs to be fixed to have normal drink dispensers instead of these subtypes.

Secondly, these mapping subtypes are intentionally unable to be deconstructed, because they have bonuses much better than normal chem dispensers.

I'll be closing this

@thgvr thgvr closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants