missing icon unit test #2530
Merged
missing icon unit test #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FalloutFalcon
changed the title
MarkSuckerberg
approved these changes
Dec 6, 2023
|
Yea I have been trying to get around to fixing as many as I can but haven't found the time yet. I might go through and just change them to something we already have for all of them even if it doesn't match. Alot of them aren't seen anyway for various reasons. |
|
If we get all of the sprites on the master fixed in this pr then i also dont have to make a follow up for uncommenting a single line to make them proper fails for the test |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to missing-icon
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MarkSuckerberg
force-pushed
the
missing-icon
branch
from
d4682f6
to
b0e041e
Compare
shiptest-server
pushed a commit
that referenced
this pull request
Mar 27, 2024
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Apr 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ports tests related to icons from tg a lot of missing sprites while most of the "missing" sprites don't really matter for multiple reasons: - Some sprites simply overwrite there icon_state on inits and alot completely ignore the icon like with limbs - Others are completely unused/unobtainble content like old Chaplin - A shit ton of items declare items states but dont have a sprite to match. For nearly all of these you can just remove the line as not every item needs a inhand state - Items that equip to the belt slot but dont have a icon in the belt dmi to match there icon_state fail. We have a seperate var specificly for declaring the icon for wearing it we can fix most of these with. the tests should help for debugging future prs once we get all of the current sprites fixed If anyone wants to help go through and fix em it would really help because there is over 1000 fails at this time of writing For fixing sprites that aren't important im going to skim through our current sprites and tgs but I dont have the time to make new ones. Should fix shiptest-ss13#2619 and shiptest-ss13#1275 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> helps find missing icons? fixes a shit ton of sprites <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: code: various missing icon unit tests fix: to many sprites to name /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com> Co-authored-by: Mark Suckerberg <mark@suckerberg.gay>
MysticalFaceLesS
pushed a commit
to CeladonSS13/Shiptest
that referenced
this pull request
Apr 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ports tests related to icons from tg a lot of missing sprites while most of the "missing" sprites don't really matter for multiple reasons: - Some sprites simply overwrite there icon_state on inits and alot completely ignore the icon like with limbs - Others are completely unused/unobtainble content like old Chaplin - A shit ton of items declare items states but dont have a sprite to match. For nearly all of these you can just remove the line as not every item needs a inhand state - Items that equip to the belt slot but dont have a icon in the belt dmi to match there icon_state fail. We have a seperate var specificly for declaring the icon for wearing it we can fix most of these with. the tests should help for debugging future prs once we get all of the current sprites fixed If anyone wants to help go through and fix em it would really help because there is over 1000 fails at this time of writing For fixing sprites that aren't important im going to skim through our current sprites and tgs but I dont have the time to make new ones. Should fix shiptest-ss13#2619 and shiptest-ss13#1275 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> helps find missing icons? fixes a shit ton of sprites <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: code: various missing icon unit tests fix: to many sprites to name /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com> Co-authored-by: Mark Suckerberg <mark@suckerberg.gay>
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
ports tests related to icons from tg
a lot of missing sprites
while most of the "missing" sprites don't really matter for multiple reasons:
the tests should help for debugging future prs once we get all of the current sprites fixed
If anyone wants to help go through and fix em it would really help because there is over 1000 fails at this time of writing
For fixing sprites that aren't important im going to skim through our current sprites and tgs but I dont have the time to make new ones.
Should fix #2619 and #1275
Why It's Good For The Game
helps find missing icons?
fixes a shit ton of sprites
Changelog
🆑
code: various missing icon unit tests
fix: to many sprites to name
/:cl: