Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing icon unit test #2530

Merged
merged 87 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
6a14d4b
missing icon unit test
FalloutFalcon Nov 26, 2023
c74c477
prob the issue
FalloutFalcon Nov 26, 2023
83aacf4
what about this?
FalloutFalcon Nov 26, 2023
750f6b3
log world for now
FalloutFalcon Nov 26, 2023
746ea31
what about worn states
FalloutFalcon Nov 26, 2023
53d50b2
not this pr.. need to wewrite most of that
FalloutFalcon Nov 26, 2023
a7c1cf7
Merge branch 'master' into missing-icon
FalloutFalcon Dec 6, 2023
2d9496c
lets see if this works for body parts?
FalloutFalcon Dec 6, 2023
b92efde
alot
FalloutFalcon Dec 6, 2023
11ff1c6
more
FalloutFalcon Dec 6, 2023
32024a4
mostly body parts
FalloutFalcon Dec 6, 2023
b14c364
shrug
FalloutFalcon Dec 6, 2023
8406cec
idk
FalloutFalcon Dec 6, 2023
f2fa27d
testing out some other missing icon unit tests?
FalloutFalcon Dec 6, 2023
16a7d77
forgot the include
FalloutFalcon Dec 6, 2023
fc24500
fixing merge conflict
FalloutFalcon Dec 6, 2023
df5235f
Merge branch 'master' into missing-icon
FalloutFalcon Dec 6, 2023
84d0aa7
Commiting to the goal. No missing sprites, 2025
FalloutFalcon Dec 6, 2023
0fb8640
sort them?
FalloutFalcon Dec 6, 2023
2388e6b
how bout dis
FalloutFalcon Dec 6, 2023
bf5c7b6
shifts drinks. Will seperate it into pieces later
FalloutFalcon Dec 6, 2023
b0d9291
hmmm
FalloutFalcon Dec 7, 2023
f9f2d98
shrug
FalloutFalcon Dec 7, 2023
9c20a83
hm
FalloutFalcon Dec 7, 2023
42ee582
mabye
FalloutFalcon Dec 7, 2023
53e6aba
inhandicon to item
FalloutFalcon Dec 7, 2023
5071860
drinks?
FalloutFalcon Dec 7, 2023
33f1223
i will write this for glass_icon_states later
FalloutFalcon Dec 7, 2023
ae3621d
idk
FalloutFalcon Dec 7, 2023
8929cc3
Fixing some fake fails i think
FalloutFalcon Dec 7, 2023
29af592
pointless and fake
FalloutFalcon Dec 7, 2023
216f0ec
make it just for clothing. Will prb xpand bck latr
FalloutFalcon Dec 7, 2023
ae1abd3
commenting out really slow test frn
FalloutFalcon Dec 7, 2023
1394888
minor fixes
FalloutFalcon Dec 7, 2023
e9cf6da
so many items states
FalloutFalcon Dec 7, 2023
38fee94
inhand clothing misc
FalloutFalcon Dec 7, 2023
cc0926d
headset and some others
FalloutFalcon Dec 7, 2023
e9bb935
Merge remote-tracking branch 'upstream/master' into missing-icon
FalloutFalcon Dec 18, 2023
6be40d3
Want to see how this works
FalloutFalcon Dec 18, 2023
b6f8e24
That makes sense
FalloutFalcon Dec 18, 2023
4565a89
Not worth
FalloutFalcon Dec 18, 2023
ce34774
poor owl suit
FalloutFalcon Dec 18, 2023
18de1d1
does .. nothing?
FalloutFalcon Dec 18, 2023
117d062
some stuff
FalloutFalcon Dec 19, 2023
693f59a
more
FalloutFalcon Dec 19, 2023
c904328
ports the clothing inhands folder from tg
FalloutFalcon Dec 19, 2023
0fe754a
test his
FalloutFalcon Dec 19, 2023
d00a322
yea?
FalloutFalcon Dec 19, 2023
c7564ab
earmuffs, crazy
FalloutFalcon Dec 19, 2023
1ed6d04
i hate inhands so much now
FalloutFalcon Dec 19, 2023
9519959
outfit names
FalloutFalcon Dec 19, 2023
b7f02b8
Killed a bit of LT stuff
FalloutFalcon Dec 19, 2023
bf2fe3e
yea
FalloutFalcon Dec 19, 2023
8d45611
some more fixes
FalloutFalcon Dec 20, 2023
6d99ea2
Merge branch 'master' into missing-icon
FalloutFalcon Dec 20, 2023
0122905
so much cruft
FalloutFalcon Dec 20, 2023
4832fa2
more!
FalloutFalcon Dec 20, 2023
c409bcd
gonna ignore nothings for now
FalloutFalcon Dec 20, 2023
d089077
a few more
FalloutFalcon Dec 20, 2023
00ce931
hm?
FalloutFalcon Dec 20, 2023
5578ed7
Merge branch 'master' into missing-icon
FalloutFalcon Dec 24, 2023
612e43f
ahj
FalloutFalcon Dec 28, 2023
a059a6f
Merge branch 'master' into missing-icon
FalloutFalcon Jan 11, 2024
2ff1d34
trailing newline
FalloutFalcon Jan 11, 2024
81037a6
random sprite fixes
FalloutFalcon Jan 11, 2024
e6b6206
small
FalloutFalcon Jan 11, 2024
3a259df
Fix #2619
FalloutFalcon Jan 11, 2024
8eebc07
#1275
FalloutFalcon Jan 11, 2024
71e11eb
#1275
FalloutFalcon Jan 11, 2024
08436bf
generic wall locker
FalloutFalcon Jan 11, 2024
85542cf
idk man
FalloutFalcon Jan 11, 2024
eacd085
Merge branch 'master' into missing-icon
FalloutFalcon Jan 12, 2024
4d3a577
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Jan 22, 2024
0543031
Merge branch 'master' into missing-icon
FalloutFalcon Jan 30, 2024
dc70fdb
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Feb 14, 2024
ea2df88
Merge branch 'master' into missing-icon
FalloutFalcon Feb 20, 2024
f441fd9
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Mar 5, 2024
7128c84
aughhhh
FalloutFalcon Mar 5, 2024
8021f4d
yea
FalloutFalcon Mar 5, 2024
507a9be
wooo
FalloutFalcon Mar 5, 2024
4187b4b
wha eva
FalloutFalcon Mar 5, 2024
b6f4b5e
wehar
FalloutFalcon Mar 5, 2024
c7a9c17
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Mar 16, 2024
73e8c51
Merge branch 'master' into missing-icon
FalloutFalcon Mar 18, 2024
32e8ae0
yea
FalloutFalcon Mar 21, 2024
b0e041e
why are my tests playing
FalloutFalcon Mar 22, 2024
3f32d74
Merge remote-tracking branch 'upstream/master' into missing-icon
MarkSuckerberg Mar 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _maps/RandomRuins/JungleRuins/jungle_paradise.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
/turf/open/floor/mineral/plastitanium/red/brig,
/area/overmap_encounter/planetoid/cave/explored)
"bh" = (
/obj/item/clothing/under/rank/civilian/cookjorts,
/obj/item/clothing/under/shorts/cookjorts,
/turf/closed/mineral/random/jungle,
/area/overmap_encounter/planetoid/cave/explored)
"bj" = (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@
},
/obj/effect/mob_spawn/human/corpse/damaged,
/obj/item/clothing/under/rank/civilian/chaplain,
/obj/item/clothing/suit/chaplainsuit/witchhunter,
/obj/item/clothing/head/helmet/chaplain/witchunter_hat,
/obj/effect/decal/cleanable/blood,
/obj/effect/decal/cleanable/glass,
Expand Down
2 changes: 1 addition & 1 deletion _maps/outpost/nanotrasen_asteroid.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -14592,7 +14592,7 @@
dir = 8;
pixel_x = 28
},
/obj/item/clothing/under/rank/civilian/cookjorts,
/obj/item/clothing/under/shorts/cookjorts,
/obj/item/clothing/shoes/cookflops,
/obj/item/clothing/suit/toggle/chef,
/obj/item/clothing/under/rank/civilian/chef,
Expand Down
6 changes: 3 additions & 3 deletions _maps/shuttles/minutemen/minutemen_vela.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -7779,9 +7779,9 @@
/obj/effect/turf_decal/corner_steel_grid{
dir = 9
},
/obj/item/clothing/under/rank/civilian/cookjorts,
/obj/item/clothing/under/rank/civilian/cookjorts,
/obj/item/clothing/under/rank/civilian/cookjorts,
/obj/item/clothing/under/shorts/cookjorts,
/obj/item/clothing/under/shorts/cookjorts,
/obj/item/clothing/under/shorts/cookjorts,
/turf/open/floor/pod/dark,
/area/ship/cargo)
"Qg" = (
Expand Down
2 changes: 1 addition & 1 deletion _maps/shuttles/nanotrasen/nanotrasen_heron.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -4155,7 +4155,7 @@
dir = 8;
pixel_x = 28
},
/obj/item/clothing/under/rank/civilian/cookjorts,
/obj/item/clothing/under/shorts/cookjorts,
/obj/item/clothing/shoes/cookflops,
/obj/item/clothing/suit/toggle/chef,
/obj/item/clothing/under/rank/civilian/chef,
Expand Down
2 changes: 0 additions & 2 deletions code/datums/martial/krav_maga.dm
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@
name = "krav maga gloves"
desc = "These gloves can teach you to perform Krav Maga using nanochips."
icon_state = "fightgloves"
item_state = "fightgloves"
cold_protection = HANDS
min_cold_protection_temperature = GLOVES_MIN_TEMP_PROTECT
heat_protection = HANDS
Expand All @@ -214,7 +213,6 @@
name = "combat gloves plus"
desc = "These tactical gloves are fireproof and electrically insulated, and through the use of nanochip technology will teach you the martial art of krav maga."
icon_state = "black"
item_state = "blackgloves"
siemens_coefficient = 0
permeability_coefficient = 0.05
strip_delay = 80
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/doors/door.dm
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/obj/machinery/door
name = "door"
desc = "It opens and closes."
icon = 'icons/obj/doors/Doorint.dmi'
icon = 'icons/obj/doors/doorf.dmi'
icon_state = "door1"
base_icon_state = "door"
opacity = TRUE
Expand Down
12 changes: 6 additions & 6 deletions code/game/machinery/droneDispenser.dm
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@
/obj/machinery/droneDispenser/swarmer
name = "swarmer fabricator"
desc = "An alien machine of unknown origin. It whirs and hums with green-blue light, the air above it shimmering."
icon = 'icons/obj/machines/gateway.dmi'
icon_state = "toffcenter"
icon_off = "toffcenter"
icon_on = "toffcenter"
icon_recharging = "toffcenter"
icon_creating = "offcenter"
icon = 'icons/obj/objects.dmi'
icon_state = "hivebot_fab"
icon_off = "hivebot_fab"
icon_on = "hivebot_fab"
icon_recharging = "hivebot_fab"
icon_creating = "hivebot_fab_on"
metal_cost = 0
glass_cost = 0
cooldownTime = 300 //30 seconds
Expand Down
1 change: 1 addition & 0 deletions code/game/objects/effects/contraband.dm
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
var/original_name
desc = "A large piece of space-resistant printed paper."
icon = 'icons/obj/contraband.dmi'
icon_state = "poster_ripped"
anchored = TRUE
var/ruined = FALSE
/// how do we want to handle the random poster pool? POSTER_SUBTYPES chooses randomly from subtypes, AKA how it was handled before
Expand Down
8 changes: 4 additions & 4 deletions code/game/objects/effects/decals/cleanable/robots.dm
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@
random_icon_states = list("gibarm", "gibleg")

/obj/effect/decal/cleanable/robot_debris/up
icon_state = "gibup1"
random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6", "gib7","gibup1","gibup1")
icon_state = "gibup"
random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6", "gib7","gibup","gibup")

/obj/effect/decal/cleanable/robot_debris/down
icon_state = "gibdown1"
random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6", "gib7","gibdown1","gibdown1")
icon_state = "gibdown"
random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6", "gib7","gibdown","gibdown")

/obj/effect/decal/cleanable/oil
name = "motor oil"
Expand Down
1 change: 1 addition & 0 deletions code/game/objects/effects/decals/crayon.dm
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ GLOBAL_LIST(gang_tags)
name = "Leet Like Jeff K gang tag"
desc = "Looks like someone's claimed this area for Leet Like Jeff K."
icon = 'icons/obj/gang/tags.dmi'
icon_state = "B_tag"
layer = BELOW_MOB_LAYER
var/datum/team/gang/my_gang

Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/effects/decals/decal.dm
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

/obj/effect/turf_decal
icon = 'icons/turf/decals.dmi'
icon_state = "warningline"
icon_state = "warningfulltile"
plane = FLOOR_PLANE
layer = TURF_DECAL_LAYER
var/detail_overlay
Expand Down
8 changes: 0 additions & 8 deletions code/game/objects/effects/decals/turfdecal/flooring_decals.dm
Original file line number Diff line number Diff line change
Expand Up @@ -416,14 +416,6 @@ TURF_DECAL_COLOR_HELPER(transparent/inteqbrown, "#4b2a18", 140)
icon_state = "plaque"
icon = 'icons/turf/decals.dmi'

/obj/effect/turf_decal/asteroid
name = "random asteroid rubble"
icon_state = "asteroid0"

/obj/effect/turf_decal/asteroid/New()
icon_state = "asteroid[rand(0,9)]"
..()

/obj/effect/turf_decal/chapel
name = "chapel"
icon_state = "chapel"
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/effects/landmarks.dm
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ INITIALIZE_IMMEDIATE(/obj/effect/landmark)

/obj/effect/landmark/start/psychologist
name = "Psychologist"
icon_state = "Psychologist"
icon_state = "Curator"

/obj/effect/landmark/start/chaplain
name = "Chaplain"
Expand Down
10 changes: 0 additions & 10 deletions code/game/objects/effects/misc.dm
Original file line number Diff line number Diff line change
@@ -1,12 +1,3 @@
//The effect when you wrap a dead body in gift wrap
/obj/effect/spresent
name = "strange present"
desc = "It's a ... present?"
icon = 'icons/obj/items_and_weapons.dmi'
icon_state = "strangepresent"
density = TRUE
anchored = FALSE

/obj/effect/beam
name = "beam"
var/def_zone
Expand Down Expand Up @@ -83,7 +74,6 @@
/obj/effect/abstract/marker/at
name = "active turf marker"


/obj/effect/dummy/lighting_obj
name = "lighting fx obj"
desc = "Tell a coder if you're seeing this."
Expand Down
9 changes: 3 additions & 6 deletions code/game/objects/effects/temporary_visuals/miscellaneous.dm
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,14 @@
/obj/effect/temp_visual/dir_setting/wraith
name = "shadow"
icon = 'icons/mob/mob.dmi'
icon_state = "phase_shift2"
icon_state = "revenant_idle"
duration = 6

/obj/effect/temp_visual/dir_setting/wraith/angelic
icon_state = "phase_shift2_angelic"

/obj/effect/temp_visual/dir_setting/wraith/out
icon_state = "phase_shift"

/obj/effect/temp_visual/dir_setting/wraith/out/angelic
icon_state = "phase_shift_angelic"

/obj/effect/temp_visual/dir_setting/tailsweep
icon_state = "tailsweep"
Expand Down Expand Up @@ -157,7 +154,7 @@
fades = TRUE

/obj/effect/temp_visual/dir_setting/curse/hand
icon_state = "cursehand"
icon_state = "cursehand0"

/obj/effect/temp_visual/dir_setting/space_wind
icon = 'icons/effects/atmospherics.dmi'
Expand All @@ -174,7 +171,7 @@
name = "\improper Bluespace energy wave"
desc = "A massive, rippling wave of bluepace energy, all rapidly exhausting itself the moment it leaves the concentrated beam of light."
icon = 'icons/effects/beam_splash.dmi'
icon_state = "beam_splash_l"
icon_state = "beam_splash_e"
layer = ABOVE_ALL_MOB_LAYER
pixel_y = -16
duration = 50
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
icon_state = "muzzle_laser"

/obj/effect/projectile/muzzle/laser/blue
icon_state = "muzzle_laser_blue"
icon_state = "muzzle_blue"

/obj/effect/projectile/muzzle/laser/emitter
name = "emitter flash"
Expand Down
2 changes: 0 additions & 2 deletions code/game/objects/items/binoculars.dm
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
desc = "Used for long-distance surveillance."
item_state = "binoculars"
icon_state = "binoculars"
lefthand_file = 'icons/mob/inhands/items_lefthand.dmi'
righthand_file = 'icons/mob/inhands/items_righthand.dmi'
slot_flags = ITEM_SLOT_BELT
w_class = WEIGHT_CLASS_SMALL
var/mob/listeningTo
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/items/chrono_eraser.dm
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
/obj/item/ammo_casing/energy/chrono_beam
name = "eradication beam"
projectile_type = /obj/projectile/energy/chrono_beam
icon_state = "chronobolt"
icon_state = "caseless"
e_cost = 0
var/obj/item/gun/energy/chrono_gun/gun

Expand Down
4 changes: 0 additions & 4 deletions code/game/objects/items/cigs_lighters.dm
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ CIGARETTE PACKETS ARE IN FANCY.DM
damtype = "fire"
force = 3
hitsound = 'sound/items/welder.ogg'
item_state = "cigon"
name = "lit [initial(name)]"
desc = "A [initial(name)]. This one is lit."
attack_verb = list("burnt","singed")
Expand All @@ -59,7 +58,6 @@ CIGARETTE PACKETS ARE IN FANCY.DM
damtype = "brute"
force = initial(force)
icon_state = "match_burnt"
item_state = "cigoff"
name = "burnt [initial(name)]"
desc = "A [initial(name)]. This one has seen better days."
attack_verb = list("flicked")
Expand Down Expand Up @@ -116,7 +114,6 @@ CIGARETTE PACKETS ARE IN FANCY.DM
desc = "A roll of tobacco and nicotine."
icon_state = "cigoff"
throw_speed = 0.5
item_state = "cigoff"
w_class = WEIGHT_CLASS_TINY
body_parts_covered = null
grind_results = list()
Expand Down Expand Up @@ -418,7 +415,6 @@ CIGARETTE PACKETS ARE IN FANCY.DM
icon_off = "cigaroff" //make sure to add positional sprites in icons/obj/cigarettes.dmi if you add more.
type_butt = /obj/item/cigbutt/cigarbutt
throw_speed = 0.5
item_state = "cigaroff"
smoketime = 300 // 11 minutes
chem_volume = 40
list_reagents = list(/datum/reagent/drug/nicotine = 25)
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/items/devices/flashlight.dm
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@
name = "banana lamp"
desc = "Only a clown would think to make a ghetto banana-shaped lamp. Even has a goofy pullstring."
icon_state = "bananalamp"
item_state = "bananalamp"
item_state = "lampgreen"

// FLARES

Expand Down
1 change: 0 additions & 1 deletion code/game/objects/items/devices/pressureplates.dm
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
name = "pressure plate"
desc = "An electronic device that triggers when stepped on. Ctrl-Click to toggle the pressure plate off and on."
icon = 'icons/obj/puzzle_small.dmi'
item_state = "flash"
icon_state = "pressureplate"
layer = LOW_OBJ_LAYER
var/trigger_mob = TRUE
Expand Down
4 changes: 2 additions & 2 deletions code/game/objects/items/devices/radio/encryptionkey.dm
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

/obj/item/encryptionkey/minutemen
name = "minutemen encryption key"
icon_state = "clip_cypherkey"
icon_state = "cmm_cypherkey"
channels = list(RADIO_CHANNEL_MINUTEMEN = 1)

/obj/item/encryptionkey/inteq
Expand All @@ -57,7 +57,7 @@

/obj/item/encryptionkey/headset_com
name = "command radio encryption key"
icon_state = "comm_cypherkey"
icon_state = "com_cypherkey"
channels = list(RADIO_CHANNEL_COMMAND = 1)

/obj/item/encryptionkey/heads/captain
Expand Down
Loading
Loading