Retry trivy when it fails to download the vulnerability database due to rate-limiting

[SaschaSchwarze0]

Changes

Part of #1689

This changes the image processing step to perform a simple retry in case of Trivy failures due to rate limiting.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

The image-processing step now retries the vulnerability scan using Trivy if that failed to download the vulnerability database due to rate-limiting

[SaschaSchwarze0]

@HeavyWombat just seeing in your PR this error: 2024-10-28T14:13:11Z FATAL Fatal error init error: DB error: failed to download vulnerability DB: OCI artifact error: failed to download vulnerability DB: failed to download artifact from any source

Should I do the retry also for this error (and remove the TOOMANYREQUESTS check) ?

Edit: is also in my PR. :-)

[SaschaSchwarze0]

This looks promising, only one failure in the integration test suite which is unrelated and which is a flaky test that I address here: #1701

[HeavyWombat]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HeavyWombat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment