-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak file listing to omit .git
directory
#1722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
In almost all cases, the `.git` directory content is not directly helpful in the file listing and it leads to a lot of noise in the output. Do not show `.git` files in file listing, but show a summary of size and file count at the end in the footer section. Signed-off-by: Matthias Diester <matthias.diester@de.ibm.com>
c02bba7
to
8fb1e54
Compare
Rebased to get the BuildKit fix to get e2e green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
In almost all cases, the
.git
directory content is not directly helpful in the file listing and it leads to a lot of noise in the output.Do not show
.git
files in file listing, but show a summary of size and file count at the end in the footer section.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
/kind cleanup
Release Notes