Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of "new" as variable name #1731

Merged

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Golangci-lint started to complain the usage of new as variable name: https://github.com/shipwright-io/build/actions/runs/11785633189/job/32827274452?pr=1730

  Running [/home/runner/golangci-lint-1.62.0-linux-amd64/golangci-lint run --path-prefix=go/src/github.com/shipwright-io/build --timeout=10m] in [/home/runner/work/build/build/go/src/github.com/shipwright-io/build] ...
  Error: go/src/github.com/shipwright-io/build/pkg/env/env.go:17:19: redefines-builtin-id: redefinition of the built-in function new (revive)
  func MergeEnvVars(new []corev1.EnvVar, into []corev1.EnvVar, overwriteValues bool) ([]corev1.EnvVar, error) {
                    ^
  Error: go/src/github.com/shipwright-io/build/pkg/volumes/volumes.go:72:65: redefines-builtin-id: redefinition of the built-in function new (revive)
  func MergeBuildVolumes(into []buildv1beta1.BuildStrategyVolume, new []buildv1beta1.BuildVolume) ([]buildv1beta1.BuildStrategyVolume, error) {

I am renaming those two.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@SaschaSchwarze0 SaschaSchwarze0 added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 11, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Nov 11, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Nov 11, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2024
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7df1d2d into shipwright-io:main Nov 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants