Merge pull request #1716 from NitroCao/fix/pidfd

fix: release process after os.FindProcess()
shirou · Dec 14, 2024 · 2a70d27 · 2a70d27
2 parents c95f835 + fcdd277
commit 2a70d27
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/process/process_posix.go b/process/process_posix.go
@@ -108,6 +108,7 @@ func PidExistsWithContext(ctx context.Context, pid int32) (bool, error) {
 	if err != nil {
 		return false, err
 	}
+	defer proc.Release()
 
 	if isMount(common.HostProcWithContext(ctx)) { // if /<HOST_PROC>/proc exists and is mounted, check if /<HOST_PROC>/proc/<PID> folder exists
 		_, err := os.Stat(common.HostProcWithContext(ctx, strconv.Itoa(int(pid))))
@@ -144,6 +145,7 @@ func (p *Process) SendSignalWithContext(ctx context.Context, sig syscall.Signal)
 	if err != nil {
 		return err
 	}
+	defer process.Release()
 
 	err = process.Signal(sig)
 	if err != nil {

diff --git a/process/process_windows.go b/process/process_windows.go
@@ -817,6 +817,7 @@ func (p *Process) KillWithContext(ctx context.Context) error {
 	if err != nil {
 		return err
 	}
+	defer process.Release()
 	return process.Kill()
 }