removing unused members

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
shiv0408 · Jun 7, 2024 · c492b18 · c492b18
1 parent ba069ec
commit c492b18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/server/src/main/java/org/opensearch/gateway/remote/model/RemoteClusterMetadataManifest.java b/server/src/main/java/org/opensearch/gateway/remote/model/RemoteClusterMetadataManifest.java
@@ -36,6 +36,8 @@ public class RemoteClusterMetadataManifest extends AbstractRemoteWritableBlobEnt
 
     public static final String METADATA_MANIFEST_NAME_FORMAT = "%s";
     public static final int MANIFEST_CURRENT_CODEC_VERSION = ClusterMetadataManifest.CODEC_V3;
+    public static final String COMMITTED = "C";
+    public static final String PUBLISHED = "P";
 
     /**
      * Manifest format compatible with older codec v0, where codec version was missing.
@@ -93,11 +95,10 @@ public String generateBlobFileName() {
             MANIFEST,
             RemoteStoreUtils.invertLong(clusterMetadataManifest.getClusterTerm()),
             RemoteStoreUtils.invertLong(clusterMetadataManifest.getStateVersion()),
-            (clusterMetadataManifest.isCommitted() ? "C" : "P"), // C for committed and P for published
+            (clusterMetadataManifest.isCommitted() ? COMMITTED : PUBLISHED),
             RemoteStoreUtils.invertLong(System.currentTimeMillis()),
-            String.valueOf(clusterMetadataManifest.getCodecVersion()) // Keep the codec version at last place only, during read we reads
-                                                                      // last place to
-            // determine codec version.
+            String.valueOf(clusterMetadataManifest.getCodecVersion())
+            // Keep the codec version at last place only, during we read last place to determine codec version.
         );
         this.blobFileName = blobFileName;
         return blobFileName;

diff --git a/server/src/main/java/org/opensearch/gateway/remote/model/RemoteGlobalMetadata.java b/server/src/main/java/org/opensearch/gateway/remote/model/RemoteGlobalMetadata.java
@@ -30,9 +30,6 @@ public class RemoteGlobalMetadata extends AbstractRemoteWritableBlobEntity<Metad
         Metadata::fromXContent
     );
 
-    private Metadata metadata;
-    private final String blobName;
-
     public RemoteGlobalMetadata(
         final String blobName,
         final String clusterUUID,

diff --git a/server/src/test/java/org/opensearch/gateway/remote/model/RemoteIndexMetadataTests.java b/server/src/test/java/org/opensearch/gateway/remote/model/RemoteIndexMetadataTests.java
@@ -160,7 +160,7 @@ public void testGetUploadedMetadata() throws IOException {
         try (InputStream inputStream = remoteObjectForUpload.serialize()) {
             remoteObjectForUpload.setFullBlobName(new BlobPath().add(TEST_BLOB_PATH));
             UploadedMetadata uploadedMetadata = remoteObjectForUpload.getUploadedMetadata();
-            assertThat(uploadedMetadata.getUploadedFilename(), is(remoteObjectForUpload.getFullBlobName()));
+            assertThat(uploadedMetadata.getUploadedFilename(), is(remoteObjectForUpload.getBlobFileName()));
         }
     }