Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

installer/CMakeLists.txt

@@ -1,14 +1,14 @@
 # see - http://www.cmake.org/Wiki/CMake_FAQ#Is_there_an_option_to_produce_more_.27verbose.27_compiling.3F
 # SET(CMAKE_VERBOSE_MAKEFILE ON)
+
 cmake_minimum_required(VERSION 3.6)
+
 project("quad-pres")
 
 INCLUDE ("${CMAKE_SOURCE_DIR}/cmake/shlomif_common_bootstrap.cmake")
 SHLOMIF_COMMON_SETUP("${private_mod_path}")
 
-
 SET (PKGDATADIR "${DATADIR}/quad-pres")
-
 SET (PATH_PERL "${PKGDATADIR}/perl5")
 
 add_subdirectory(perl5)

installer/perl5/CMakeLists.txt

@@ -21,7 +21,7 @@ SET (d "${CMAKE_CURRENT_BINARY_DIR}/Shlomif/Quad/Pres/Path.pm")
 ADD_CUSTOM_COMMAND(
     OUTPUT "${d}"
     COMMAND "${PERL_EXECUTABLE}"
-    ARGS "-E" "use Path::Tiny qw/ path /; use File::Basename qw( dirname) ; use File::Path qw/ mkpath/ ; my $t = path(\"${s}\")->slurp_raw; $t =~ s#\\{QP_MODULES_DIR\\}#${PATH_PERL}#g; $t =~ s#\\{QP_PKG_DATA_DIR\\}#${PKGDATADIR}#g; $t =~ s#/usr/bin/perl#${PATH_PERL}#g; mkpath([dirname(\"${d}\")]); path(\"${d}\")->spew_raw($t);"
+    ARGS "-E" "use Path::Tiny qw/ path /; my $t = path(\"${s}\")->slurp_raw(); $t =~ s#\\{QP_MODULES_DIR\\}#${PATH_PERL}#g; $t =~ s#\\{QP_PKG_DATA_DIR\\}#${PKGDATADIR}#g; $t =~ s#/usr/bin/perl#${PERL_EXECUTABLE}#g; path(\"${d}\")->touchpath()->spew_raw($t);"
     DEPENDS "${s}"
     VERBATIM
 )

installer/perl5/Shlomif/Quad/Pres/Path.pm.pl

@@ -24,28 +24,21 @@ sub _init
 
 sub get_modules_dir
 {
-    my $self = shift;
-
     return $modules_dir;
 }
 
 sub get_scripts_dir
 {
-    my $self = shift;
-
     return $scripts_dir;
 }
 
 sub get_template_dir
 {
-    my $self = shift;
     return $template_dir;
 }
 
 sub get_wml_dir
 {
-    my $self = shift;
-
     return $wml_dir;
 }
 

installer/perl5/quadp.pl

@@ -1,4 +1,6 @@
-#!/usr/bin/perl -I{QP_MODULES_DIR}
+#!/usr/bin/perl
+
+use lib q#{QP_MODULES_DIR}#;
 
 use strict;
 use warnings;