Merge branch 'next' into konnorrogers/fix-multiple-identical-spritesh…

…eet-icons
shoelace-style · Sep 23, 2024 · 21aa4b7 · 21aa4b7
2 parents 30248b8 + 91193e2
commit 21aa4b7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md
@@ -16,6 +16,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
 
 - Fixed a bug in `<sl-icon>` not applying the mutator when loading multiple icons of the same name from a spritesheet. [#2178]
 - Fixed a bug in `<sl-select>` that made the suffix slot collide with the clear button [#2145]
+- Improved performance of `<sl-popup>` by waiting for the active state before spinning up the positioning library [#2179]
 
 ## 2.17.0
 

diff --git a/src/components/popup/popup.component.ts b/src/components/popup/popup.component.ts
@@ -264,7 +264,7 @@ export default class SlPopup extends ShoelaceElement {
     }
 
     // If the anchor is valid, start it up
-    if (this.anchorEl) {
+    if (this.anchorEl && this.active) {
       this.start();
     }
   }