-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2078: Send event if image load fails, update changelog closes #2123
#2078: Send event if image load fails, update changelog closes #2123
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
If you're interested in this feature, LMK, and I can also add to the "should not render the image when the image fails to load" unit test. |
Thanks for the PR! I'm fine with this with one minor suggestion. Feel free to add a test if you'd like. |
Renamed, added test |
@@ -62,7 +70,7 @@ export default class SlAvatar extends ShoelaceElement { | |||
src="${this.image}" | |||
loading="${this.loading}" | |||
alt="" | |||
@error="${() => (this.hasError = true)}" | |||
@error="${this.onImageLoadError}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@error="${this.onImageLoadError}" | |
@error="${this.handleImageLoadError}" |
See #2122