SG-17742 Attempt to fix the crash issue with Houdini #83
+73
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
reviewed
Jan 16, 2024
julien-lang
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the tk-multi-shotgunpanel in Houdini, the Houdini app crashes on exit. This has been reported by the community.
This PR attempts to fix this by properly destroying Qt objects on close. This solution was inspired on tk-multi-workfiles2.
destroymethod from tk-framework-shotgunutils instead of QtdeleteLaterwhich causes issues with the garbage collector.This PR requires shotgunsoftware/tk-framework-shotgunutils#149