This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Use the ChatGPT generated gas price padding function when purchasing a creator token #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeavaldez
requested review from
intergalacticspacehighway,
alantoa and
hirbod
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There is no gasPrice returned from simulation, this has to be done differently |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The simulated contract function request payload seems to have discrepancies with the quoted gas price between the Alchemy rpc and the user wallet rpc.
How
https://showtime-xyz.slack.com/archives/C02PXGK3V8D/p1698699732510189
I took whatever chat gpt did here and added it in the
useCreatorTokenBuyhook.This doesn't seem correct though. Because this is an eip 1559 transaction but gas price is not an eip 1559 thing.
We probably need to do this to the following:
Test Plan
Staging