Fix improper activeThreads increments (issue 1842) #1845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves issue 1842 - Improper threads synchronization in the ThreadBarrier leading to snapshot failures.
Goals
Fix the logic of the ThreadBarrier class to not increment activeThreads counter when threadBarrier.enter() is called in the same thread for which the counter has already been incremented. Used ThreadLocal to maintain counter of enter method invocations within the current thread. Used custom wrapper class MutualInteger for it as it's 5-6x faster than use of threadLocal's get() and set():
Security checks