fix: use correct default search domain #10031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
fix/searchdomain
branch
from
1d5c6b3 to
04d579b
Compare
|
Can we add what was expected and what was actual as an example? |
DmitriyMV
approved these changes
Dec 24, 2024
example.org vs. foo.example.org |
frezbo
approved these changes
Dec 24, 2024
smira
force-pushed
the
fix/searchdomain
branch
from
04d579b to
129b4a3
Compare
Search domain should be domain name of the hostname, not the FQDN. Bug introduced in siderolabs#9844 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/searchdomain
branch
from
129b4a3 to
5f3acd0
Compare
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search domain should be domain name of the hostname, not the FQDN.
Bug introduced in #9844