Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage.md instructions for disabling mayastor nvme-tcp check #10064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timolson
Copy link

Documentation addition to further describe disabling of mayastor's nvme-tcp check

Signed-off-by: Tim Olson <shamme@gmail.com>
@timolson
Copy link
Author

I still cannot get Mayastor working on Talos 1.9.0, so this edit may not be helpful. After adding nvme-tcp to the kernel modules (an instruction which is also missing from the docs), it was no longer necessary to disable this init container, since it did detect nvme-tcp successfully. However, Mayastor is still not working on 1.9.0.

The OpenEBS ZFS provisioner also seems broken in 1.9.0.

Let me also say that the migration from 1.8.3 to 1.9.0 has been very painful for us. I would hope that minor dot releases are basically backward compatible but the alteration of security contexts (and perhaps default modules? How did this every work previously without explicitly loading nvme-tcp?) broke many things for us. :((((

The documentation in Talos and OpenEBS both seem outdated. If I can get Mayastor running on 1.9.0, I'll send another documentation PR.

@timolson timolson closed this Dec 27, 2024
@timolson
Copy link
Author

I've confirmed that these changes are necessary.

I also added the nvme-tcp module explicitly to my machineconfigs, but it's not clear if this is necessary or if that is a default module in Talos.

It also required an upgrade to 1.9.1, since the deadlock bug in 1.9.0 was a significant problem.

Please incorporate the doc changes in this PR, and if it makes sense to also update the machineconfig patch with the nvme-tcp module, I can submit a PR for that, too. LMK.

@timolson timolson reopened this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant