Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Target Android API level 26 #6900

Closed
ghost opened this issue Aug 27, 2017 · 3 comments
Closed

[Feature Request] Target Android API level 26 #6900

ghost opened this issue Aug 27, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 27, 2017

Please target Android API Level 26 so Signal will respect Background Execution Limits
https://developer.android.com/about/versions/oreo/background.html

@moxie0
Copy link
Contributor

moxie0 commented Aug 28, 2017

The Play version of Signal doesn't do any work in the background, other than an occasional (like once every 48hrs) periodic task which uses the system-appropriate scheduling, or a DB write in the execution window that we get following a GCM or SMS event. Whether or not Signal is targeting API level 26 should have no bearing on its background execution, since there is no background execution that I know of.

@moxie0 moxie0 closed this as completed Aug 28, 2017
@ghost
Copy link
Author

ghost commented Aug 28, 2017

@moxie0 I disagree see Bug #6898 if Signal was targeting 26 whatever defect in your codebase that is causing Signal to drain in the background would not occur because Android 8.0's background limits would kick in and kill signal's excessive background drain.

The background limits in Android 8.0 only work if the app targets API Level 26.

I have submitted a PR to bump the SdkVersion of which you guys were targeting an unofficial Lollipop level? Why? #6901

@ghost ghost mentioned this issue Aug 28, 2017
1 task
@moxie0
Copy link
Contributor

moxie0 commented Aug 28, 2017

If there is some kind of "defective" background execution, I would love to fix it, so let's start there. Any insight into background execution that you're seeing would be wonderful, but I'm not sure why there would be background execution on Android 8 and not Android 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant