Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not assume a build's purpose based on its target architecture #57

Open
brjsp opened this issue Oct 9, 2024 · 2 comments
Open

do not assume a build's purpose based on its target architecture #57

brjsp opened this issue Oct 9, 2024 · 2 comments

Comments

@brjsp
Copy link

brjsp commented Oct 9, 2024

commit be737c3 removes some features on linux aarch64 (and only aarch64), i'm assuming because they are only used by the electron app.

I maintain the signal-desktop package in openSUSE. in addition to x86_64, we also provide aarch64, armhf and riscv64 versions. We'd like to keep the application fully-functional across all architectures.

If you need to build a version of ringrtc with some functionality disabled in your CI, please cleanly delineate it as a cargo feature instead of making such assumptions.

@mutexlox-signal
Copy link
Contributor

The problem that be737c3 is trying to fix is that we have a dep that was failing to build on aarch64 linux (see mozilla/cubeb-rs#97).

This is a short-term workaround to avoid breaking the build until that dep is fixed and the fix is pushed to crates.io; we do want to build this feature for aarch64 linux once that's done.

@mutexlox-signal
Copy link
Contributor

BTW, thanks for your work on maintaining the package for openSUSE :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants