deps: fetch build artefacts using a proxy where necessary #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I have now signed the CLA!) |
rashad-signal
suggested changes
Nov 7, 2023
|
Updated per your review, thanks! I've done the same over on signalapp/better-sqlite3#12 |
rashad-signal
approved these changes
Nov 9, 2023
|
Thanks for making the changes. It's now available in 9dca1e6 which is part of RingRTC v2.34.4. |
|
Thanks @rashad-signal! Do I need to do anything with the similar pull on better-sqlite3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been struggling to build Signal from source where the build machine is behind a proxy.
This change will have no effect during build unless the
HTTPS_PROXYvariable is set, in which case it establishes an agent that will ensure thehttps.getcalls use the proxy correctly.I'm open to suggestions on a different approach if the addition of another dependency is too undesirable.