code review

sigp · Jul 14, 2023 · 8e52dde · 8e52dde
1 parent 893617f
commit 8e52dde
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/components/DropDown/DropDown.tsx b/src/components/DropDown/DropDown.tsx
@@ -15,8 +15,6 @@ const DropDown: FC<DropDownProps> = ({
   className = '',
   position = 'top-full left-0 z-50',
 }) => {
-  const isChildrenArray = Array.isArray(children)
-
   return (
     <div
       id='dropdown'
@@ -25,9 +23,7 @@ const DropDown: FC<DropDownProps> = ({
       } ${className} ${position} animate-fadeSlideIn bg-white rounded divide-y divide-gray-100 shadow dark:bg-black`}
     >
       <ul
-        className={`text-sm max-h-32 overflow-scroll relative text-gray-700 dark:text-gray-200 ${
-          isChildrenArray && children.length >= 4 ? '' : ''
-        }`}
+        className='text-sm max-h-32 overflow-scroll relative text-gray-700 dark:text-gray-200'
         aria-labelledby='dropdownDefault'
       >
         {children}

diff --git a/src/hooks/__tests__/useDeviceDiagnostics.spec.ts b/src/hooks/__tests__/useDeviceDiagnostics.spec.ts
@@ -11,7 +11,7 @@ jest.mock('../../utilities/formatGigBytes', () => jest.fn())
 jest.mock('../useDiagnosticAlerts', () => ({
   __esModule: true,
   default: jest.fn(() => ({
-    alerts: [], // Your desired formatted list of alerts
+    alerts: [],
     storeAlert: jest.fn(),
     updateAlert: jest.fn(),
     dismissAlert: jest.fn(),