run make depsupdate #179
run make depsupdate #179
Conversation
hobbitronics
requested review from
a team,
briskt,
forevermatt,
mtompset and
jason-jackson
and removed request for
a team
| @@ -1,14 +1,20 @@ | |||
| { | |||
| "version": "6.0.0", | |||
There was a problem hiding this comment.
I don't recall this being here, or if we have a process to make sure it shows the correct version at release time. Maybe it doesn't matter much unless it shows in Sentry logs or AWS logs.
There was a problem hiding this comment.
It has been in the package.json file, but didn't ever get updated until we installed sentry. I suppose we could add it to a checklist, maybe in the PR template (which doesn't exist yet)
| "name": "idp-profile-ui", | ||
| "dependencies": { | ||
| "@babel/polyfill": { | ||
| "version": "7.12.1", | ||
| "resolved": "https://registry.npmjs.org/@babel/polyfill/-/polyfill-7.12.1.tgz", | ||
| "overridden": false | ||
| }, | ||
| "@sentry/vue": { |
There was a problem hiding this comment.
I don't understand why vue is just now showing up as a dependency.
There was a problem hiding this comment.
I forgot to run make depsupdate after installing sentry and probably other times dependencies were changed. Probably another thing to add to a checklist in a PR template.
| "@simplewebauthn/browser": { | ||
| "version": "4.1.0", | ||
| "resolved": "https://registry.npmjs.org/@simplewebauthn/browser/-/browser-4.1.0.tgz", | ||
| "version": "9.0.1", |
There was a problem hiding this comment.
big jump! How long has it been since the last update?
There was a problem hiding this comment.
Another time I forgot to run make depsupdate. See #169 for details, but the short story is the repo has ui and server, and most of the changes happen in the server code, so not many breaking changes in the ui code.
|
No description provided.