Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow PDNS_NO_NOTIFY to contain [ no | false ] #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

theAsylum-dk
Copy link

I'm fairly sure I'm not the only one to get caught out by setting PDNS_NO_NOTIFY to 'no' or 'false' and not seeing the expected behaviour? ;)

@silkeh
Copy link
Owner

silkeh commented May 30, 2023

Thanks! Unfortunately, your changes do not pass shellcheck. Please run shellcheck and fix any complaints.

You can either run shellcheck locally, or rebase on master to let the CI do it for you (Travis broke again for some reason, so I switched to GitLab CI).

Copy link
Owner

@silkeh silkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants