Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User typeahead enabled for non-admin project managers #1237

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

User typeahead enabled for non-admin project managers #1237

wants to merge 19 commits into from

Commits on Nov 14, 2024

  1. Add UsersICanSee GQL mutation, managed projects only

    @rmunn
    rmunn committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    24dd849 View commit details
    Browse the repository at this point in the history

  2. Update UsersICanSee mutation for all projects

    @rmunn
    rmunn committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1bb9efa View commit details
    Browse the repository at this point in the history

  3. Use usersICanSee query in typeahead

    @rmunn
    rmunn committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    09a6bcf View commit details
    Browse the repository at this point in the history

  4. Add tests verifying the usersICanSee query

    @rmunn
    rmunn committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    abb53c0 View commit details
    Browse the repository at this point in the history

  5. Don't need to create two projects for this test

    @rmunn
    rmunn committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6149d78 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Move typeahead query into UserService 

    Now the test can be a proper unit test rather than an integration test.
    @rmunn
    rmunn committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dcbd530 View commit details
    Browse the repository at this point in the history

  2. Add disposable temp project fixture 

    This avoids having to use `try ... finally` blocks in the tests, making
them more reliable.
    @rmunn
    rmunn committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a0f89f1 View commit details
    Browse the repository at this point in the history

  3. Treat isConfidential = null as false in UsersICanSee

    @rmunn
    rmunn committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    44db0e3 View commit details
    Browse the repository at this point in the history

  4. Fix UserServiceTest not running

    @rmunn
    rmunn committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2d0a7c5 View commit details
    Browse the repository at this point in the history

  5. Fix task for generating GQL schema

    @myieye
    myieye committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0dbbcd9 View commit details
    Browse the repository at this point in the history

  6. Complete rename to usersICanSee

    @myieye
    myieye committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    10619d4 View commit details
    Browse the repository at this point in the history

  7. Exclude existing users from typeahead results

    @myieye
    myieye committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4dcdfda View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Test a lot more scenarios in UserServiceTest

    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    af79417 View commit details
    Browse the repository at this point in the history

  2. Tweak some tests in preparation for adding orgs

    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e31d6d6 View commit details
    Browse the repository at this point in the history

  3. Add more test scenarios with organizations

    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    42f2442 View commit details
    Browse the repository at this point in the history

  4. Order of users returned from query does not matter

    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e037ab9 View commit details
    Browse the repository at this point in the history

  5. Greatly simplify test output of failing tests

    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f1747b2 View commit details
    Browse the repository at this point in the history

  6. Add failing test for one edge case 

    A member of private projects should be able to see himself, but
currently he cannot. He could if he was in an org, but he cannot see
himself if he's in one private project but no orgs.
    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3ac2011 View commit details
    Browse the repository at this point in the history

  7. Fix failing test where user couldn't see himself

    @rmunn
    rmunn committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8930e88 View commit details
    Browse the repository at this point in the history