Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new diff update API #1249

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Use new diff update API #1249

merged 6 commits into from
Nov 19, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Nov 18, 2024 •
edited
Loading

Resolves #1245
Resolves #1099

So far it seems to just work 😎

  • Random edits
  • Changing Semantic domains in every way I can think of
  • Adding and removing complex forms and components

You know it was an awesome backend improvement when the frontend changes are 90% deletions 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 878262e. ± Comparison against base commit 412aa71.

♻️ This comment has been updated with latest results.

hahn-kev
hahn-kev previously approved these changes Nov 19, 2024
View reviewed changes
@myieye myieye merged commit 24959dd into develop Nov 19, 2024
14 checks passed
@myieye myieye deleted the 1245-use-new-update-api-on-frontend branch November 19, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahn-kev hahn-kev hahn-kev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use new Update api on frontend Changing entries in a list results in unsupported JSON patch operations
2 participants
@myieye @hahn-kev