-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-3054 Warn user when saving a note without content #2851
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2851 +/- ##
==========================================
- Coverage 79.19% 79.18% -0.02%
==========================================
Files 533 533
Lines 30953 30961 +8
Branches 5050 5052 +2
==========================================
+ Hits 24514 24517 +3
- Misses 5655 5669 +14
+ Partials 784 775 -9 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/note-dialog/note-dialog.component.ts
line 70 at r1 (raw file):
showSegmentText: boolean = false; notesToDisplay: NoteDisplayInfo[] = []; _saveOption: 'save' | 'resolve' = 'save';
Nit: Can we please make this a type as it is repeated a couple of times?
Code quote:
_saveOption: 'save' | 'resolve' = 'save';
e215c0a
to
0abc700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @pmachapman)
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/note-dialog/note-dialog.component.ts
line 70 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
Nit: Can we please make this a type as it is repeated a couple of times?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)
This change adds form validation to the note dialog form when adding or editing notes. If a user tries to save an empty note, they will be prompted to enter text rather than having the dialog close without any action.
This change is