Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylelint warnings #228

Closed
3 tasks done
sabina-talipova opened this issue Apr 22, 2024 · 1 comment
Closed
3 tasks done

Remove stylelint warnings #228

sabina-talipova opened this issue Apr 22, 2024 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Apr 22, 2024

Description

After sass-lint was replaced by stylelint, it became necessary to bring existing code into compliance with the new rules so that all style files adhered to the basic rules.

Mostly this is a deviation from the rules in the writing and use of the color name instead of the hex code, indents before blocks and at the beginning of the file, empty comments. You need to go through all the modules from the list and run a lint check. Any warnings that occur must be corrected or removed from the list of rules in the .stylelintrc.yml file if they are not appropriate.

Acceptance criteria

  • There are no stylelint warnings on any supported modules
  • The 'defaultSeverity': 'warning' line is removed from .stylelintrc.js in the shared lint config
  • Paths being ignored are evaluated - stop ignoring "legacy" code, since we're still maintaining it.

PRs

This PR must be merged first so I can update the yarn deps for all the other repos, or else the linting in CI for the PRs will be using the outdated rules.

Lint fixing PRs

Reassign to Guy if these are still draft - but make sure you merge the above PR first!

@GuySartorelli GuySartorelli self-assigned this Jun 5, 2024
This was referenced Jun 5, 2024
@emteknetnz
Copy link
Member

Have merged first PR, assigning back to Guy to create 1.3.0 eslint-config release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants