Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run module-standardiser #242

Closed
4 tasks
emteknetnz opened this issue May 7, 2024 · 3 comments
Closed
4 tasks

Run module-standardiser #242

emteknetnz opened this issue May 7, 2024 · 3 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented May 7, 2024

A bunch of modules in https://rhino.silverstripe.org/?t=merge-ups do not have merge-up workflow on the repo

Notes

  • The cron time on ALL repos will change for all cron based worfklows - this is expected for this run and will not happen in subsequent runs
  • This will be the first time standardiser has been run after updating it to use the new silverstripe/supported-modules set of repositories.
    • If any repos in that list should not be included in standardiser for some reason, add an exclusion list to module-standardiser somewhere, and update the docs for setting up a new repo.

Acceptance criteria

  • Run module-standardiser across all repos
  • Ensure that the merge-ups are added to all non-recipes on repos that follow standard branching conventions i.e. 1/1.0/2/2.0 style - note - there's a separate card to handle non-silverstripe repos on the wrong default branch
  • Ensure that the auto-tag workflow is on all workflow repos (note that regular tagging happens in ci.yml and action-ci.yml)
  • Ensure that all relevant workflow files have the correct permissions added - see GitHub Workflows security hardening silverstripe-framework#10510

Module standardiser PR

PRs

Follow up PRs to fix crons

PRs for tooling / workflow / misc repos

@GuySartorelli
Copy link
Member

There's no PR for https://github.com/silverstripe/documentation-lint, and probably others that also need them.

@GuySartorelli
Copy link
Member

Just one PR needs attention: silverstripe/documentation-lint#4

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants