Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run translations #83

Closed
github-actions bot opened this issue Aug 1, 2023 · 2 comments
Closed

Run translations #83

github-actions bot opened this issue Aug 1, 2023 · 2 comments
Assignees
@GuySartorelli
Labels
affects/v4 affects/v5 impact/low type/enhancement

Comments

@github-actions
Copy link

github-actions bot commented Aug 1, 2023 •
edited by GuySartorelli
Loading

This is an automatically created issue used to run translations every 3 months.

It was created by the .github/workflows/translation-issue.yml workflow in the silverstripe/.github repository.

Triage instructions (Silverstripe Ltd CMS Squad)

  1. Put on the following labels:
    • type/enhancement
    • impact/low
    • affects/v4
    • affects/v5
  2. Move this issue to the "Ready" column on our internal zenhub board

Implementation instructions:

  1. Create an install of kitchen-sink using the latest next-minor branch e.g. 5
  2. Also install silverstripe/tx-translator
  3. Follow the instructions in the tx-translator README.md and do a TX_PULL=0 TX_COLLECT=1 TX_PUSH=1 run.
  4. This may create lots of pull-requests. Paste links to these pull request on this issue.
  5. Once the pull-requests have been merged, create a new install of kitchen-sink using the oldest supported minor branch e.g. 4.13
  6. Also install silverstripe/tx-translator
  7. Follow the instructions in the tx-translator README.md and do a TX_PULL=1 TX_COLLECT=0 TX_PUSH=0 run.
  8. This will create lots of pull-requests. Paste links to these pull request on this issue.
  9. Once these pull-requests have been merged, merge them up all the way through to the next-minor branch e.g. 5. If this step has been automated then you do not need to do anything.
  10. Create new patch releases for all supported branches on all repositories that have new translations. If this step has been automated then you do not need to do anything.

CMS5 PRs

CMS 4 PRs
@GuySartorelli GuySartorelli mentioned this issue Aug 18, 2023
Merged
@GuySartorelli GuySartorelli removed their assignment Aug 18, 2023
@emteknetnz emteknetnz self-assigned this Aug 21, 2023
@emteknetnz
Copy link
Member

@GuySartorelli Re the 2x PRs with english translations in the wrong files - should close the existing wrong PRs, go into transifex and delete the translations that shouldn't be there and then re-rerun the tx-translator for 4.13

@GuySartorelli
Copy link
Member

I've closed those two PRs and raised silverstripe/silverstripe-tx-translator#18 separately for fixing this problem.
Closing this issue as all its linked PRs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v4 affects/v5 impact/low type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli