Merge branch '3.0' into 3

silverstripe · Sep 1, 2024 · 9c5484c · 9c5484c
2 parents 3377ce7 + 437b7de
commit 9c5484c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 20 deletions.
diff --git a/_config/extensions.yml b/_config/extensions.yml
@@ -1,12 +1,6 @@
 ---
 Name: cwpcoreextensions
 ---
-# @todo Disable the feature. LoginAttempt seems to be broken on bridging solution - logs every
-# request instead of logins!
-# Follow up issue: https://github.com/silverstripe/cwp-core/issues/41
-# SilverStripe\Admin\LeftAndMain:
-#   extensions:
-#     - CWP\Core\Extension\LoginAttemptNotifications
 
 SilverStripe\ORM\FieldType\DBField:
   extensions:
@@ -16,7 +10,6 @@ SilverStripe\Security\Group:
   extensions:
     - CWP\Core\Extension\CwpHtmlEditorConfig
 
-# @todo investigate replacement for this
 HtmlEditorField_Toolbar:
   extensions:
    - CWP\Core\Extension\CustomHtmlEditorFieldToolbar
diff --git a/src/Extension/CustomHtmlEditorField.php b/src/Extension/CustomHtmlEditorField.php
@@ -7,9 +7,6 @@
 use SilverStripe\View\Requirements;
 
 /**
- * @todo rename file to match class name
- * @todo investigate updated HTMLEditorField_Toolbar changes, and find new implementation
- *
  * @extends Extension<\HtmlEditorField_Toolbar>
  */
 class CustomHtmlEditorFieldToolbar extends Extension

diff --git a/src/Extension/LoginAttemptNotifications.php b/src/Extension/LoginAttemptNotifications.php
@@ -10,8 +10,6 @@
 use SilverStripe\View\Requirements;
 
 /**
- * TODO: describe.
- * TODO: bug when using default admin - always shows the message...
  * Requires Security::login_recording config to be set to true.
  *
  * @extends Extension<LeftAndMain>
@@ -66,14 +64,12 @@ public function init()
 
                     $message .= "The attempts were from " . implode(', ', $IPs) . '. ';
 
-                    // TODO: add this call to action in a way that doesn't break out of the availabel space. Fix CSS?
-                    // $message .= "If you suspect somebody else might be trying to access
-                    //  . "your account, please contact support.";
+                    $message .= "If you suspect somebody else might be trying to access "
+                    . "your account, please contact support.";
                 }
             }
         } else {
             // New session - show last login attempt.
-            // TODO: this currently does NOT surface to the frontend in any way.
             $lastLoginAttempt = LoginAttempt::get()->filter([
                         'MemberID' => $member->ID
             ])->sort('Created DESC')->First();

diff --git a/src/Feed/CwpAtomFeed.php b/src/Feed/CwpAtomFeed.php
@@ -6,7 +6,6 @@
  * CwpAtomFeed class
  *
  * This class is used to create an Atom feed.
- * @todo Improve documentation
  * @package cwp-core
  */
 use SilverStripe\Control\Controller;

diff --git a/tests/AtomFeedTest.php b/tests/AtomFeedTest.php
@@ -65,8 +65,8 @@ protected function setUp(): void
     {
         parent::setUp();
         Config::modify()->set(Director::class, 'alternate_base_url', '/');
-        if (!self::$original_host) {
-            self::$original_host = $_SERVER['HTTP_HOST'];
+        if (!AtomFeedTest::$original_host) {
+            AtomFeedTest::$original_host = $_SERVER['HTTP_HOST'];
         }
         $_SERVER['HTTP_HOST'] = 'www.example.org';
     }
@@ -75,6 +75,6 @@ protected function tearDown(): void
     {
         parent::tearDown();
         Config::modify()->set(Director::class, 'alternate_base_url', null);
-        $_SERVER['HTTP_HOST'] = self::$original_host;
+        $_SERVER['HTTP_HOST'] = AtomFeedTest::$original_host;
     }
 }